| Message ID | 1279219653-12791-1-git-send-email-segooon@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Thu, 15 Jul 2010 22:47:33 +0400 Kulikov Vasiliy <segooon@gmail.com> wrote: > ipv6_skip_exthdr() can return error code that is below zero. > 'offset' is unsigned, so it makes no sense. > ipv6_skip_exthdr() returns 'int' so we can painlessly change type of > offset to int. > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> > --- > net/bridge/br_multicast.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c > index 27ae946..85afcda 100644 > --- a/net/bridge/br_multicast.c > +++ b/net/bridge/br_multicast.c > @@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br, > struct icmp6hdr *icmp6h; > u8 nexthdr; > unsigned len; > - unsigned offset; > + int offset; > int err; > > if (!pskb_may_pull(skb, sizeof(*ip6h))) Acked-by: Stephen Hemminger <shemminger@vyatta.com>
From: Stephen Hemminger <shemminger@linux-foundation.org> Date: Thu, 15 Jul 2010 12:21:44 -0700 > On Thu, 15 Jul 2010 22:47:33 +0400 > Kulikov Vasiliy <segooon@gmail.com> wrote: > >> ipv6_skip_exthdr() can return error code that is below zero. >> 'offset' is unsigned, so it makes no sense. >> ipv6_skip_exthdr() returns 'int' so we can painlessly change type of >> offset to int. >> >> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> ... > Acked-by: Stephen Hemminger <shemminger@vyatta.com> Applied. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index 27ae946..85afcda 100644 --- a/net/bridge/br_multicast.c +++ b/net/bridge/br_multicast.c @@ -1435,7 +1435,7 @@ static int br_multicast_ipv6_rcv(struct net_bridge *br, struct icmp6hdr *icmp6h; u8 nexthdr; unsigned len; - unsigned offset; + int offset; int err; if (!pskb_may_pull(skb, sizeof(*ip6h)))
ipv6_skip_exthdr() can return error code that is below zero. 'offset' is unsigned, so it makes no sense. ipv6_skip_exthdr() returns 'int' so we can painlessly change type of offset to int. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- net/bridge/br_multicast.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)