From patchwork Tue Jul 13 11:22:18 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 58766 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id B14D9B6F1A for ; Tue, 13 Jul 2010 21:23:08 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348Ab0GMLWt (ORCPT ); Tue, 13 Jul 2010 07:22:49 -0400 Received: from mail-vw0-f46.google.com ([209.85.212.46]:54679 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753902Ab0GMLWp (ORCPT ); Tue, 13 Jul 2010 07:22:45 -0400 Received: by vws5 with SMTP id 5so5667886vws.19 for ; Tue, 13 Jul 2010 04:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=BX0NaGGO2PIuq/eMzVsoIVoaFZi667llyD679j5d9Qw=; b=PQf7rlOLryt//MPQtZtOWR7cj3CIMG8gIT94/HuT2Ri50AFkkdiMuPpeXUtrUBM2zg qU32DzoCqUuJrlTWkrVJUh8H5AfqbEQzcMdMP6CUTVbAKuqQZG6dvjEocGX47ncMkBPw BIeGgZUXG1MvTBlmOT2P0x3O5gVBhdUcqgAhY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=rfebZ9JYUfqkCu77EycD4t6xX261wRx7ZRfa3VghVNcex8q/2LAAwpo3NJNob4f1cD 00FgEuVTa6ZiqKmk5HoQCjs7f7Lzd0qfodkPLrwwkt05d9HPLZTvOHrRQt4GOy8cwdc8 gzH7lGoKkGkZ9vyEzN0Wn+E/bWYiVav8KZZm4= Received: by 10.224.72.215 with SMTP id n23mr8498485qaj.357.1279020164345; Tue, 13 Jul 2010 04:22:44 -0700 (PDT) Received: from localhost ([213.87.80.145]) by mx.google.com with ESMTPS id e1sm4891948vch.20.2010.07.13.04.22.30 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 13 Jul 2010 04:22:42 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: Mika Kuoppala , "David S. Miller" , Stephen Hemminger , Eric Dumazet , Tejun Heo , Jiri Pirko , netdev@vger.kernel.org Subject: [PATCH] eth16i: fix memory leak Date: Tue, 13 Jul 2010 15:22:18 +0400 Message-Id: <1279020138-9398-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Free allocated netdev if no probe is expected. Signed-off-by: Kulikov Vasiliy --- drivers/net/eth16i.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/net/eth16i.c b/drivers/net/eth16i.c index 874973f..2bdd394 100644 --- a/drivers/net/eth16i.c +++ b/drivers/net/eth16i.c @@ -1442,8 +1442,10 @@ int __init init_module(void) dev->if_port = eth16i_parse_mediatype(mediatype[this_dev]); if(io[this_dev] == 0) { - if(this_dev != 0) /* Only autoprobe 1st one */ + if (this_dev != 0) { /* Only autoprobe 1st one */ + free_netdev(def); break; + } printk(KERN_NOTICE "eth16i.c: Presently autoprobing (not recommended) for a single card.\n"); }