From patchwork Fri Jul 9 12:28:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kulikov Vasiliy X-Patchwork-Id: 58398 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5F6C2B6F0E for ; Fri, 9 Jul 2010 22:28:31 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755956Ab0GIM21 (ORCPT ); Fri, 9 Jul 2010 08:28:27 -0400 Received: from mail-ew0-f46.google.com ([209.85.215.46]:56355 "EHLO mail-ew0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755855Ab0GIM20 (ORCPT ); Fri, 9 Jul 2010 08:28:26 -0400 Received: by ewy23 with SMTP id 23so457845ewy.19 for ; Fri, 09 Jul 2010 05:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=2lgtcZysD3lYOtuKvD26YaZs0byZ06UM1USqXzHTwM8=; b=JNqN5NHgiy0rQmGHB9dy3hIp7wFlb051atdIyaR77x3dassenlEjjMH8ZdwiUXw+9a UxKzy1/n+iw8ixyZlyp7920ALotcR0IPy/K4MdDhP9arywOhc8Fjw2bAQ/RxnyEsCWkr W9ywr+5Rk2bWvTa862mkVptTX3d1QWIfPQ5L8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=mDdFFrqE4GHgjie36m/pkSKf41zI8htiD/cudYuOvT/XplBVXua1z1AM+xvQ5z65iL xR1wwQBEJjgyTxDIXsj44opnfqgfGC6Qq7Q81CK3QflrWihzSOxlhoz4gXLqXIW0jLmd 8NDRnlxB0V+rsADbKTAOJIT3oHEjv8vR18+CY= Received: by 10.213.90.132 with SMTP id i4mr7780278ebm.55.1278678503502; Fri, 09 Jul 2010 05:28:23 -0700 (PDT) Received: from localhost ([213.87.80.19]) by mx.google.com with ESMTPS id x54sm7165880eeh.11.2010.07.09.05.28.18 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Jul 2010 05:28:22 -0700 (PDT) From: Kulikov Vasiliy To: kernel-janitors@vger.kernel.org Cc: "David S. Miller" , Joe Perches , netdev@vger.kernel.org Subject: [PATCH] ac3200: fix error path Date: Fri, 9 Jul 2010 16:28:09 +0400 Message-Id: <1278678489-7053-1-git-send-email-segooon@gmail.com> X-Mailer: git-send-email 1.7.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Do not call free_irq() if request_irq() failed. Signed-off-by: Kulikov Vasiliy --- drivers/net/ac3200.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/ac3200.c b/drivers/net/ac3200.c index b9115a7..5181e93 100644 --- a/drivers/net/ac3200.c +++ b/drivers/net/ac3200.c @@ -211,7 +211,7 @@ static int __init ac_probe1(int ioaddr, struct net_device *dev) retval = request_irq(dev->irq, ei_interrupt, 0, DRV_NAME, dev); if (retval) { printk (" nothing! Unable to get IRQ %d.\n", dev->irq); - goto out1; + goto out; } printk(" IRQ %d, %s port\n", dev->irq, port_name[dev->if_port]);