| Message ID | 1278173056-11779-1-git-send-email-segooon@gmail.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, 3 Jul 2010, Kulikov Vasiliy wrote: > Use for_each_pci_dev() to simplify the code. > > Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> > --- > drivers/net/irda/smsc-ircc2.c | 5 +---- > 1 files changed, 1 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c > index d67e484..850ca1c 100644 > --- a/drivers/net/irda/smsc-ircc2.c > +++ b/drivers/net/irda/smsc-ircc2.c > @@ -2848,9 +2848,7 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, > unsigned short ss_device = 0x0000; > int ret = 0; > > - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); > - > - while (dev != NULL) { > + for_each_pci_dev(dev) { > struct smsc_ircc_subsystem_configuration *conf; > > /* > @@ -2899,7 +2897,6 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, > ret = -ENODEV; > } > } > - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); > } > > return ret; Doesn't seem to hit linux-next as of today. Dave, are you going to merge it? Thanks,
From: Jiri Kosina <jkosina@suse.cz> Date: Tue, 20 Jul 2010 17:33:01 +0200 (CEST) > On Sat, 3 Jul 2010, Kulikov Vasiliy wrote: > >> Use for_each_pci_dev() to simplify the code. >> >> Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> >> --- ... > Doesn't seem to hit linux-next as of today. Dave, are you going to merge > it? I'll apply this now, thanks. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/irda/smsc-ircc2.c b/drivers/net/irda/smsc-ircc2.c index d67e484..850ca1c 100644 --- a/drivers/net/irda/smsc-ircc2.c +++ b/drivers/net/irda/smsc-ircc2.c @@ -2848,9 +2848,7 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, unsigned short ss_device = 0x0000; int ret = 0; - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); - - while (dev != NULL) { + for_each_pci_dev(dev) { struct smsc_ircc_subsystem_configuration *conf; /* @@ -2899,7 +2897,6 @@ static int __init smsc_ircc_preconfigure_subsystems(unsigned short ircc_cfg, ret = -ENODEV; } } - dev = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, dev); } return ret;
Use for_each_pci_dev() to simplify the code. Signed-off-by: Kulikov Vasiliy <segooon@gmail.com> --- drivers/net/irda/smsc-ircc2.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-)