From patchwork Fri May 21 12:58:33 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Eilon Greenstein X-Patchwork-Id: 53152 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8E947B7D5B for ; Fri, 21 May 2010 22:58:55 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035Ab0EUM6t (ORCPT ); Fri, 21 May 2010 08:58:49 -0400 Received: from mms3.broadcom.com ([216.31.210.19]:4985 "EHLO MMS3.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753238Ab0EUM6s convert rfc822-to-8bit (ORCPT ); Fri, 21 May 2010 08:58:48 -0400 Received: from [10.9.200.131] by MMS3.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Fri, 21 May 2010 05:58:38 -0700 X-Server-Uuid: B55A25B1-5D7D-41F8-BC53-C57E7AD3C201 Received: from mail-irva-12.broadcom.com (10.11.16.101) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Fri, 21 May 2010 05:58:39 -0700 Received: from [10.185.6.73] (lb-tlvb-eilong.il.broadcom.com [10.185.6.73]) by mail-irva-12.broadcom.com (Postfix) with ESMTP id E35D569CA8; Fri, 21 May 2010 05:58:36 -0700 (PDT) Subject: Re: bnx2x + SFP+ DA/2.6.33.3: Got bad status 0x0 when reading from SFP+ EEPROM -> SFP+ module is not initialized From: "Eilon Greenstein" Reply-to: eilong@broadcom.com To: "Krzysztof =?UTF-8?Q?Ol=C4=99dzki?=" cc: "Rick Jones" , "Michael Chan" , "netdev@vger.kernel.org" In-Reply-To: <4BF5A19E.5010003@ans.pl> References: <4BF56CA6.8080306@ans.pl> <1274377770.28702.4.camel@lb-tlvb-eilong.il.broadcom.com> <4BF57ADF.1060203@ans.pl> <1274381113.28702.6.camel@lb-tlvb-eilong.il.broadcom.com> <4BF59058.6050205@ans.pl> <4BF59ABB.9070600@hp.com> <4BF5A19E.5010003@ans.pl> Organization: Broadcom Date: Fri, 21 May 2010 15:58:33 +0300 Message-ID: <1274446713.11082.3.camel@lb-tlvb-eilong.il.broadcom.com> MIME-Version: 1.0 X-Mailer: Evolution 2.28.3 X-WSS-ID: 67E85CF431G132353199-01-01 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 2010-05-20 at 13:54 -0700, Krzysztof Olędzki wrote: > On 2010-05-20 22:25, Rick Jones wrote: > > Some simple/simplistic thoughts/questions... > > > > Has the DAC been used successfully prior to this? > > Yes. It was successfully used to connect two HP switches, before I > received SFP+ SR modules, that allowed me to put the switches into > distanced rooms. Krzysztof, I would like to check in what speed the I2C is running at, and while we are there, to make sure it is at low speed (100KHz and not 400KHz). Can you please add this patch and let me know what you see: ext_phy_type, Since we are already off for the weekend, I couldn't find a machine with this kind of board to test it for myself. On top of that, I don't have this type of DAC cable, so I need your help in this debug process. Thanks, Eilon --- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/bnx2x_link.c b/drivers/net/bnx2x_link.c index ff70be8..6e05f99 100644 --- a/drivers/net/bnx2x_link.c +++ b/drivers/net/bnx2x_link.c @@ -2766,6 +2766,21 @@ static u8 bnx2x_8727_read_sfp_module_eeprom(struct link_params *params, MDIO_PMA_REG_SFP_TWO_WIRE_CTRL, &val); + /* Make sure we are working in 100KHz */ + bnx2x_cl45_read(bp, port, + PORT_HW_CFG_XGXS_EXT_PHY_TYPE_BCM8727, + ext_phy_addr, + MDIO_PMA_DEVAD, + 8005, + &val); + BNX2X_ERR("I2C 2W speed 0x%x, bit 8 %d\n", val, val & 8); + bnx2x_cl45_write(bp, port, + ext_phy_type, + ext_phy_addr, + MDIO_PMA_DEVAD, + 8005, + val & ~8); + /* Set the read command byte count */ bnx2x_cl45_write(bp, port,