Message ID | 1272293202-11712-1-git-send-email-dbaryshkov@gmail.com |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Date: Mon, 26 Apr 2010 18:46:42 +0400 > From: Stefan Schmidt <stefan@datenfreihafen.org> > > Trying to run izlisten (from lowpan-tools tests) on a device that does not > exists I got the oops below. The problem is that we are using get_dev_by_name > without checking if we really get a device back. We don't in this case and > writing to dev->type generates this oops. > > [Oops code removed by Dmitry Eremin-Solenikov] > > If possible this patch should be applied to the current -rc fixes branch. > > Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org> > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> Applied, and queued up for -stable too, thanks guys. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/ieee802154/af_ieee802154.c b/net/ieee802154/af_ieee802154.c index bad1c49..72340dd 100644 --- a/net/ieee802154/af_ieee802154.c +++ b/net/ieee802154/af_ieee802154.c @@ -147,6 +147,9 @@ static int ieee802154_dev_ioctl(struct sock *sk, struct ifreq __user *arg, dev_load(sock_net(sk), ifr.ifr_name); dev = dev_get_by_name(sock_net(sk), ifr.ifr_name); + if (!dev) + return -ENODEV; + if (dev->type == ARPHRD_IEEE802154 && dev->netdev_ops->ndo_do_ioctl) ret = dev->netdev_ops->ndo_do_ioctl(dev, &ifr, cmd);