From patchwork Sun Apr 18 09:53:01 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrew hendry X-Patchwork-Id: 50396 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D2181B7D0B for ; Sun, 18 Apr 2010 19:53:13 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302Ab0DRJxJ (ORCPT ); Sun, 18 Apr 2010 05:53:09 -0400 Received: from mail-pz0-f204.google.com ([209.85.222.204]:37498 "EHLO mail-pz0-f204.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756154Ab0DRJxF (ORCPT ); Sun, 18 Apr 2010 05:53:05 -0400 Received: by pzk42 with SMTP id 42so2815000pzk.4 for ; Sun, 18 Apr 2010 02:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:content-type :date:message-id:mime-version:x-mailer:content-transfer-encoding; bh=ddoyGOwnviv42oqu+5E86wwbH2lX/DviwqAaEH+Z2fg=; b=JRVxGFA2i9NNj7v02LZiGuhfOTHOX8igMkBjBCS8pIeuWHNtOWjQ27xk5a/SNtDtoj V9Oy9ncWqqqrRkGHi7myxJYe3pmprGpwyZSGimKF0+INjd8hPst4SfcUcwpwZPKexJyA hD3ENdxyWli5xDij0KFVWqP/OwTyN2D9TV1nM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; b=SQC1CcjM10pN3ypxReEhJlK/f2cJalk4D0eUvlHVmHml7vHUpL3f5gMOc79W50Gz2L Fu955e+SK+VwPNDDO6IevVlWR7L3Rt0tPkJVxuAMVn737CIETd+FFLV18F/Pw+nASfiS Xs6r0Tqv8WhFLPUr64m7NnM8O/3LE9RuIZ2cE= Received: by 10.114.164.20 with SMTP id m20mr3088517wae.7.1271584385195; Sun, 18 Apr 2010 02:53:05 -0700 (PDT) Received: from [192.168.0.2] (210-84-37-193.dyn.iinet.net.au [210.84.37.193]) by mx.google.com with ESMTPS id 21sm4288768pzk.0.2010.04.18.02.53.03 (version=SSLv3 cipher=RC4-MD5); Sun, 18 Apr 2010 02:53:04 -0700 (PDT) Subject: [PATCH 3/6] X25: Use identifiers for x25 async device to x25 interface From: Andrew Hendry To: netdev@vger.kernel.org Date: Sun, 18 Apr 2010 19:53:01 +1000 Message-ID: <1271584381.6280.431.camel@ibex> Mime-Version: 1.0 X-Mailer: Evolution 2.28.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Change magic numbers to identifiers for X25 interface. Signed-off-by: Andrew Hendry --- drivers/net/wan/x25_asy.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wan/x25_asy.c b/drivers/net/wan/x25_asy.c index 80d5c58..166e77d 100644 --- a/drivers/net/wan/x25_asy.c +++ b/drivers/net/wan/x25_asy.c @@ -29,12 +29,12 @@ #include #include #include -#include #include #include #include #include #include +#include #include "x25_asy.h" #include @@ -315,15 +315,15 @@ static netdev_tx_t x25_asy_xmit(struct sk_buff *skb, } switch (skb->data[0]) { - case 0x00: + case X25_IFACE_DATA: break; - case 0x01: /* Connection request .. do nothing */ + case X25_IFACE_CONNECT: /* Connection request .. do nothing */ err = lapb_connect_request(dev); if (err != LAPB_OK) printk(KERN_ERR "x25_asy: lapb_connect_request error - %d\n", err); kfree_skb(skb); return NETDEV_TX_OK; - case 0x02: /* Disconnect request .. do nothing - hang up ?? */ + case X25_IFACE_DISCONNECT: /* do nothing - hang up ?? */ err = lapb_disconnect_request(dev); if (err != LAPB_OK) printk(KERN_ERR "x25_asy: lapb_disconnect_request error - %d\n", err); @@ -411,7 +411,7 @@ static void x25_asy_connected(struct net_device *dev, int reason) } ptr = skb_put(skb, 1); - *ptr = 0x01; + *ptr = X25_IFACE_CONNECT; skb->protocol = x25_type_trans(skb, sl->dev); netif_rx(skb); @@ -430,7 +430,7 @@ static void x25_asy_disconnected(struct net_device *dev, int reason) } ptr = skb_put(skb, 1); - *ptr = 0x02; + *ptr = X25_IFACE_DISCONNECT; skb->protocol = x25_type_trans(skb, sl->dev); netif_rx(skb);