From patchwork Sat Dec 26 21:51:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Octavian Purdila X-Patchwork-Id: 41832 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 2F25CB7BFA for ; Sun, 27 Dec 2009 08:55:24 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753905AbZLZVyy (ORCPT ); Sat, 26 Dec 2009 16:54:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754047AbZLZVyu (ORCPT ); Sat, 26 Dec 2009 16:54:50 -0500 Received: from ixro-out-rtc.ixiacom.com ([92.87.192.98]:19502 "EHLO ixro-ex1.ixiacom.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753989AbZLZVyt (ORCPT ); Sat, 26 Dec 2009 16:54:49 -0500 Received: from localhost.localdomain ([10.205.9.170]) by ixro-ex1.ixiacom.com with Microsoft SMTPSVC(6.0.3790.3959); Sat, 26 Dec 2009 23:54:33 +0200 From: Octavian Purdila To: netdev@vger.kernel.org Cc: Arnaldo Carvalho de Melo , Eric Dumazet , Octavian Purdila Subject: [net-next PATCH v3 09/10] llc: remove unused APIs (which should be private anyway) Date: Sat, 26 Dec 2009 23:51:07 +0200 Message-Id: <1261864268-10460-10-git-send-email-opurdila@ixiacom.com> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1261864268-10460-1-git-send-email-opurdila@ixiacom.com> References: <1261864268-10460-1-git-send-email-opurdila@ixiacom.com> X-OriginalArrivalTime: 26 Dec 2009 21:54:33.0252 (UTC) FILETIME=[0212A640:01CA8676] Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Remove the list & lock from the exported API - it is not used anywhere in the tree and most operations should be covered by llc_sap_open(), llc_sap_close() and llc_sap_find(). Signed-off-by: Octavian Purdila --- include/net/llc.h | 1 - net/llc/llc_core.c | 4 +--- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/include/net/llc.h b/include/net/llc.h index 5503b74..915d168 100644 --- a/include/net/llc.h +++ b/include/net/llc.h @@ -93,7 +93,6 @@ struct hlist_nulls_head *llc_sk_laddr_hash(struct llc_sap *sap, #define LLC_DEST_CONN 2 /* Type 2 goes here */ extern struct list_head llc_sap_list; -extern spinlock_t llc_sap_list_lock; extern int llc_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt, struct net_device *orig_dev); diff --git a/net/llc/llc_core.c b/net/llc/llc_core.c index 78167e8..8363637 100644 --- a/net/llc/llc_core.c +++ b/net/llc/llc_core.c @@ -23,7 +23,7 @@ #include LIST_HEAD(llc_sap_list); -DEFINE_SPINLOCK(llc_sap_list_lock); +static DEFINE_SPINLOCK(llc_sap_list_lock); /** * llc_sap_alloc - allocates and initializes sap. @@ -164,8 +164,6 @@ static void __exit llc_exit(void) module_init(llc_init); module_exit(llc_exit); -EXPORT_SYMBOL(llc_sap_list); -EXPORT_SYMBOL(llc_sap_list_lock); EXPORT_SYMBOL(llc_sap_find); EXPORT_SYMBOL(llc_sap_open); EXPORT_SYMBOL(llc_sap_close);