From patchwork Fri Oct 30 18:51:56 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Grover X-Patchwork-Id: 37344 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id C8066B7C85 for ; Sat, 31 Oct 2009 05:53:20 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757309AbZJ3SxM (ORCPT ); Fri, 30 Oct 2009 14:53:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757296AbZJ3SxL (ORCPT ); Fri, 30 Oct 2009 14:53:11 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:21685 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757140AbZJ3SxK (ORCPT ); Fri, 30 Oct 2009 14:53:10 -0400 Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9UIsmxm031367 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 30 Oct 2009 18:54:49 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9UIrDf5028379; Fri, 30 Oct 2009 18:53:14 GMT Received: from abhmt005.oracle.com by acsmt353.oracle.com with ESMTP id 20733444701256928735; Fri, 30 Oct 2009 11:52:15 -0700 Received: from localhost.localdomain (/139.185.48.5) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 30 Oct 2009 11:52:14 -0700 From: Andy Grover To: netdev@vger.kernel.org Cc: rds-devel@oss.oracle.com Subject: [PATCH 4/5] RDS: Do not send congestion updates to loopback connections Date: Fri, 30 Oct 2009 11:51:56 -0700 Message-Id: <1256928717-17757-4-git-send-email-andy.grover@oracle.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1256928717-17757-1-git-send-email-andy.grover@oracle.com> References: <1256928717-17757-1-git-send-email-andy.grover@oracle.com> X-Source-IP: acsmt353.oracle.com [141.146.40.153] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4AEB3617.0192:SCFMA4539814,ss=1,fgs=0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This issue was discovered by HP's Pradeep and fixed in OFED 1.3, but not fixed in later versions, since the fix's implementation was not immediately applyable to the later code. This patch should do the trick for 1.4+ codebases. Signed-off-by: Andy Grover --- net/rds/cong.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/rds/cong.c b/net/rds/cong.c index dd2711d..6d06cac 100644 --- a/net/rds/cong.c +++ b/net/rds/cong.c @@ -218,6 +218,8 @@ void rds_cong_queue_updates(struct rds_cong_map *map) spin_lock_irqsave(&rds_cong_lock, flags); list_for_each_entry(conn, &map->m_conn_list, c_map_item) { + if (conn->c_loopback) + continue; if (!test_and_set_bit(0, &conn->c_map_queued)) { rds_stats_inc(s_cong_update_queued); queue_delayed_work(rds_wq, &conn->c_send_w, 0);