Message ID | 1254949168-12404-2-git-send-email-nicolas.2p.debian@free.fr |
---|---|
State | Accepted, archived |
Delegated to: | David Miller |
Headers | show |
From: Nicolas de Pesloüan <nicolas.2p.debian@free.fr> Date: Wed, 7 Oct 2009 22:59:28 +0200 > The variable old_active is first set to bond->curr_active_slave. > Then, it is unconditionally set to new_active, without being used in between. > > The first assignment, having no side effect, is useless. > > Signed-off-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr> > Reviewed-by: Jiri Pirko <jpirko@redhat.com> Also applied. Conclusion, avoid Thunderbird like the plague.... -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 20dc5a2..34bdea5 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1084,7 +1084,7 @@ static struct slave *bond_find_best_slave(struct bonding *bond) int mintime = bond->params.updelay; int i; - new_active = old_active = bond->curr_active_slave; + new_active = bond->curr_active_slave; if (!new_active) { /* there were no active slaves left */ if (bond->slave_cnt > 0) /* found one slave */