From patchwork Wed Sep 23 13:17:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?R=C3=A9mi_Denis-Courmont?= X-Patchwork-Id: 34159 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id CD86DB7B7C for ; Wed, 23 Sep 2009 23:17:19 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbZIWNRJ (ORCPT ); Wed, 23 Sep 2009 09:17:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750986AbZIWNRI (ORCPT ); Wed, 23 Sep 2009 09:17:08 -0400 Received: from yop.chewa.net ([91.121.105.214]:54406 "EHLO yop.chewa.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbZIWNRI (ORCPT ); Wed, 23 Sep 2009 09:17:08 -0400 Received: by yop.chewa.net (Postfix, from userid 1007) id 14EDC46E; Wed, 23 Sep 2009 15:17:11 +0200 (CEST) From: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= To: netdev@vger.kernel.org Cc: =?utf-8?q?R=C3=A9mi=20Denis-Courmont?= Subject: [PATCH] Phonet: error on broadcast sending (unimplemented) Date: Wed, 23 Sep 2009 16:17:11 +0300 Message-Id: <1253711831-7947-2-git-send-email-remi@remlab.net> X-Mailer: git-send-email 1.5.6.5 In-Reply-To: <1253711831-7947-1-git-send-email-remi@remlab.net> References: <1253711831-7947-1-git-send-email-remi@remlab.net> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Rémi Denis-Courmont From: Rémi Denis-Courmont If we ever implement this, then we can stop returning an error. Signed-off-by: Rémi Denis-Courmont --- include/linux/phonet.h | 1 + net/phonet/af_phonet.c | 6 ++++++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/linux/phonet.h b/include/linux/phonet.h index 1ef5a07..e5126cf 100644 --- a/include/linux/phonet.h +++ b/include/linux/phonet.h @@ -38,6 +38,7 @@ #define PNPIPE_IFINDEX 2 #define PNADDR_ANY 0 +#define PNADDR_BROADCAST 0xFC #define PNPORT_RESOURCE_ROUTING 0 /* Values for PNPIPE_ENCAP option */ diff --git a/net/phonet/af_phonet.c b/net/phonet/af_phonet.c index a662e62..f60c0c2 100644 --- a/net/phonet/af_phonet.c +++ b/net/phonet/af_phonet.c @@ -168,6 +168,12 @@ static int pn_send(struct sk_buff *skb, struct net_device *dev, goto drop; } + /* Broadcast sending is not implemented */ + if (pn_addr(dst) == PNADDR_BROADCAST) { + err = -EOPNOTSUPP; + goto drop; + } + skb_reset_transport_header(skb); WARN_ON(skb_headroom(skb) & 1); /* HW assumes word alignment */ skb_push(skb, sizeof(struct phonethdr));