From patchwork Fri Aug 28 21:57:50 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jay Vosburgh X-Patchwork-Id: 32471 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id C1CAFB70B3 for ; Sat, 29 Aug 2009 07:58:11 +1000 (EST) Received: by ozlabs.org (Postfix) id A8517DDDA0; Sat, 29 Aug 2009 07:58:11 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 37F99DDD1B for ; Sat, 29 Aug 2009 07:58:11 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbZH1V5z (ORCPT ); Fri, 28 Aug 2009 17:57:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752724AbZH1V5y (ORCPT ); Fri, 28 Aug 2009 17:57:54 -0400 Received: from e31.co.us.ibm.com ([32.97.110.149]:53389 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751183AbZH1V5y (ORCPT ); Fri, 28 Aug 2009 17:57:54 -0400 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id n7SLqD29009281 for ; Fri, 28 Aug 2009 15:52:13 -0600 Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id n7SLvsFY226502 for ; Fri, 28 Aug 2009 15:57:54 -0600 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n7SLvrVY011628 for ; Fri, 28 Aug 2009 15:57:54 -0600 Received: from localhost.localdomain (sig-9-65-43-152.mts.ibm.com [9.65.43.152]) by d03av04.boulder.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id n7SLvqun011527; Fri, 28 Aug 2009 15:57:53 -0600 From: Jay Vosburgh To: netdev@vger.kernel.org Cc: David Miller , Stephen Hemminger Subject: [PATCH] bonding: use compare_ether_addr Date: Fri, 28 Aug 2009 14:57:50 -0700 Message-Id: <1251496672-14498-3-git-send-email-fubar@us.ibm.com> X-Mailer: git-send-email 1.5.4.5 In-Reply-To: <1251496672-14498-2-git-send-email-fubar@us.ibm.com> References: <1251496672-14498-1-git-send-email-fubar@us.ibm.com> <1251496672-14498-2-git-send-email-fubar@us.ibm.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Hemminger Bonding can use compare_ether_addr() in bond_release. Signed-off-by: Stephen Hemminger Signed-off-by: Jay Vosburgh --- drivers/net/bonding/bond_main.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 1aeb36c..ed00ba9 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -1796,7 +1796,6 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev) struct bonding *bond = netdev_priv(bond_dev); struct slave *slave, *oldcurrent; struct sockaddr addr; - int mac_addr_differ; /* slave is not a slave or master is not master of this slave */ if (!(slave_dev->flags & IFF_SLAVE) || @@ -1820,9 +1819,8 @@ int bond_release(struct net_device *bond_dev, struct net_device *slave_dev) } if (!bond->params.fail_over_mac) { - mac_addr_differ = memcmp(bond_dev->dev_addr, slave->perm_hwaddr, - ETH_ALEN); - if (!mac_addr_differ && (bond->slave_cnt > 1)) + if (!compare_ether_addr(bond_dev->dev_addr, slave->perm_hwaddr) + && bond->slave_cnt > 1) pr_warning(DRV_NAME ": %s: Warning: the permanent HWaddr of %s - " "%pM - is still in use by %s. "