From patchwork Thu Aug 6 14:41:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Atsushi Nemoto X-Patchwork-Id: 30856 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4B892B6F34 for ; Fri, 7 Aug 2009 01:31:47 +1000 (EST) Received: by ozlabs.org (Postfix) id 407A7DDDB6; Fri, 7 Aug 2009 01:31:47 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BDD2DDDD0B for ; Fri, 7 Aug 2009 01:31:46 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755516AbZHFPbZ (ORCPT ); Thu, 6 Aug 2009 11:31:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755815AbZHFPbU (ORCPT ); Thu, 6 Aug 2009 11:31:20 -0400 Received: from mba.ocn.ne.jp ([122.28.14.163]:56607 "EHLO smtp.mba.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753826AbZHFPbT (ORCPT ); Thu, 6 Aug 2009 11:31:19 -0400 Received: from localhost.localdomain (p7206-ipad211funabasi.chiba.ocn.ne.jp [58.91.163.206]) by smtp.mba.ocn.ne.jp (Postfix) with ESMTP id 8391D659E; Thu, 6 Aug 2009 23:46:54 +0900 (JST) From: Atsushi Nemoto To: netdev@vger.kernel.org Cc: David Miller , Ralf Roesch Subject: [PATCH 5/5] tc35815: Use 0 RxFragSize.MinFrag value for non-packing mode Date: Thu, 6 Aug 2009 23:41:49 +0900 Message-Id: <1249569709-21403-5-git-send-email-anemo@mba.ocn.ne.jp> X-Mailer: git-send-email 1.5.6.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The datasheet say "When not enabling packing, the MinFrag value must remain at 0". Do not set value to RxFragSize register if TC35815_USE_PACKEDBUFFER disabled. This is not a bugfix. No real problem reported on this. Signed-off-by: Atsushi Nemoto --- drivers/net/tc35815.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/net/tc35815.c b/drivers/net/tc35815.c index 564d555..d2ca47f 100644 --- a/drivers/net/tc35815.c +++ b/drivers/net/tc35815.c @@ -2394,8 +2394,6 @@ static void tc35815_chip_init(struct net_device *dev) tc_writel(DMA_BURST_SIZE, &tr->DMA_Ctl); #ifdef TC35815_USE_PACKEDBUFFER tc_writel(RxFrag_EnPack | ETH_ZLEN, &tr->RxFragSize); /* Packing */ -#else - tc_writel(ETH_ZLEN, &tr->RxFragSize); #endif tc_writel(0, &tr->TxPollCtr); /* Batch mode */ tc_writel(TX_THRESHOLD, &tr->TxThrsh);