From patchwork Tue Jul 28 12:37:58 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Glendinning X-Patchwork-Id: 30299 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4BA8FB7B74 for ; Tue, 28 Jul 2009 22:46:02 +1000 (EST) Received: by ozlabs.org (Postfix) id 39001DDD0C; Tue, 28 Jul 2009 22:46:02 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id BB90ADDD01 for ; Tue, 28 Jul 2009 22:46:01 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753700AbZG1Mpw (ORCPT ); Tue, 28 Jul 2009 08:45:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751581AbZG1Mpw (ORCPT ); Tue, 28 Jul 2009 08:45:52 -0400 Received: from drevil.shawell.net ([86.54.240.115]:39250 "EHLO drevil2.shawell.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753233AbZG1Mpv (ORCPT ); Tue, 28 Jul 2009 08:45:51 -0400 X-Greylist: delayed 472 seconds by postgrey-1.27 at vger.kernel.org; Tue, 28 Jul 2009 08:45:51 EDT Received: from localhost.localdomain (kensington.shawell.net [10.0.20.15]) by drevil2.shawell.net (Postfix) with ESMTP id D2BF2377B5; Tue, 28 Jul 2009 13:37:58 +0100 (BST) From: Steve Glendinning To: netdev@vger.kernel.org Cc: Ian Saturley , David Miller , Steve Glendinning Subject: [PATCH] smsc95xx: remove EEPROM loaded check Date: Tue, 28 Jul 2009 13:37:58 +0100 Message-Id: <1248784678-31726-1-git-send-email-steve.glendinning@smsc.com> X-Mailer: git-send-email 1.6.2.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The eeprom read & write commands currently check the E2P_CMD_LOADED_ bit is set before allowing any operations. This prevents any reading or writing unless a correctly programmed EEPROM is installed. This patch removes the check, so it is possible to program blank EEPROMS via ethtool. Signed-off-by: Steve Glendinning --- drivers/net/usb/smsc95xx.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c index fe04589..09bd635 100644 --- a/drivers/net/usb/smsc95xx.c +++ b/drivers/net/usb/smsc95xx.c @@ -220,11 +220,6 @@ static int smsc95xx_eeprom_confirm_not_busy(struct usbnet *dev) do { smsc95xx_read_reg(dev, E2P_CMD, &val); - if (!(val & E2P_CMD_LOADED_)) { - devwarn(dev, "No EEPROM present"); - return -EIO; - } - if (!(val & E2P_CMD_BUSY_)) return 0;