From patchwork Mon Jun 29 15:02:14 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 29288 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id 9451EB7094 for ; Tue, 30 Jun 2009 01:03:37 +1000 (EST) Received: by ozlabs.org (Postfix) id 88644DDDA0; Tue, 30 Jun 2009 01:03:37 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 0C320DDD0C for ; Tue, 30 Jun 2009 01:03:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760254AbZF2PCu (ORCPT ); Mon, 29 Jun 2009 11:02:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760226AbZF2PCs (ORCPT ); Mon, 29 Jun 2009 11:02:48 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:61503 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760138AbZF2PCl (ORCPT ); Mon, 29 Jun 2009 11:02:41 -0400 Received: by fxm18 with SMTP id 18so1022550fxm.37 for ; Mon, 29 Jun 2009 08:02:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer:in-reply-to:references; bh=zKx57bU3EC3bKVzHjkFB8y/Sm9uvq/afgTCFUUJUVII=; b=MYashHne7TBQlBqo346b51dGjCFVhemMm8fz4iDB4z0Tl7KiSU6YZrrhaXyTbvYIDj t8h+Plr4CB4CWrs80udl4SgAa31PFAT7+f0pD7PyuQPW1XNkg73+s3mmlqh7kVl/FPX6 FBUXIRrGeyOgFQkR2W9dsoEaQ1tTX0k3IDLpA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; b=cIjkfpNcHj3YAndFmeMR21v0n9XzrLIu3beYO5+pua2dIDJiT8SXrSKEO4lzCBpcSV 7qvoCbRNM7V1V9dpBvRN76dmdl5zFMRXudi9fREubM7lT7PO8itCxvEv/OoxzCiEhRVi 4ISZMNYny+IYuRi9f2Uf7k4FLQBQcb3zZgfRM= Received: by 10.86.94.7 with SMTP id r7mr2184439fgb.11.1246287762679; Mon, 29 Jun 2009 08:02:42 -0700 (PDT) Received: from localhost.localdomain (iap-pxy-mow1.siemens.ru [212.248.25.26]) by mx.google.com with ESMTPS id d6sm14383043fga.15.2009.06.29.08.02.41 (version=SSLv3 cipher=RC4-MD5); Mon, 29 Jun 2009 08:02:42 -0700 (PDT) From: Dmitry Eremin-Solenikov To: "David S. Miller" Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, slapin@ossfans.org Subject: [PATCH 2/3] nl802154: fix Oops in ieee802154_nl_get_dev Date: Mon, 29 Jun 2009 19:02:14 +0400 Message-Id: <1246287735-2692-3-git-send-email-dbaryshkov@gmail.com> X-Mailer: git-send-email 1.6.3.1 In-Reply-To: <1246287735-2692-2-git-send-email-dbaryshkov@gmail.com> References: <1246287735-2692-1-git-send-email-dbaryshkov@gmail.com> <1246287735-2692-2-git-send-email-dbaryshkov@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org ieee802154_nl_get_dev() lacks check for the existance of the device that was returned by dev_get_XXX, thus resulting in Oops for non-existing devices. Fix it. Signed-off-by: Dmitry Eremin-Solenikov --- net/ieee802154/netlink.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/net/ieee802154/netlink.c b/net/ieee802154/netlink.c index 105ad10..332b947 100644 --- a/net/ieee802154/netlink.c +++ b/net/ieee802154/netlink.c @@ -276,6 +276,9 @@ static struct net_device *ieee802154_nl_get_dev(struct genl_info *info) else return NULL; + if (!dev) + return NULL; + if (dev->type != ARPHRD_IEEE802154) { dev_put(dev); return NULL;