From patchwork Tue Apr 28 14:14:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kumar Gala X-Patchwork-Id: 26567 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@bilbo.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from ozlabs.org (ozlabs.org [203.10.76.45]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mx.ozlabs.org", Issuer "CA Cert Signing Authority" (verified OK)) by bilbo.ozlabs.org (Postfix) with ESMTPS id AC76BB6F35 for ; Wed, 29 Apr 2009 00:15:01 +1000 (EST) Received: by ozlabs.org (Postfix) id 6420ADE2F2; Wed, 29 Apr 2009 00:14:27 +1000 (EST) Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 03A27DE2DE for ; Wed, 29 Apr 2009 00:14:27 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758525AbZD1OON (ORCPT ); Tue, 28 Apr 2009 10:14:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755804AbZD1OOM (ORCPT ); Tue, 28 Apr 2009 10:14:12 -0400 Received: from gate.crashing.org ([63.228.1.57]:33669 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756209AbZD1OOL (ORCPT ); Tue, 28 Apr 2009 10:14:11 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id n3SEE1Sk024273; Tue, 28 Apr 2009 09:14:02 -0500 From: Kumar Gala To: David Miller Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org Subject: [PATCH] gianfar: Use memset instead of cacheable_memzero Date: Tue, 28 Apr 2009 09:14:01 -0500 Message-Id: <1240928041-10905-1-git-send-email-galak@kernel.crashing.org> X-Mailer: git-send-email 1.6.0.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org cacheable_memzero() is completely overkill for the clearing out the FCB block which is only 8-bytes. The compiler should easily optimize this with memset. Additionally, cacheable_memzero() only exists on ppc32 and thus breaks builds of gianfar on ppc64. Signed-off-by: Kumar Gala --- drivers/net/gianfar.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index dae1437..2bb038b 100644 --- a/drivers/net/gianfar.c +++ b/drivers/net/gianfar.c @@ -1207,7 +1207,8 @@ static int gfar_enet_open(struct net_device *dev) static inline struct txfcb *gfar_add_fcb(struct sk_buff *skb) { struct txfcb *fcb = (struct txfcb *)skb_push(skb, GMAC_FCB_LEN); - cacheable_memzero(fcb, GMAC_FCB_LEN); + + memset(fcb, 0, GMAC_FCB_LEN); return fcb; }