From patchwork Mon Feb 16 07:46:06 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Glendinning X-Patchwork-Id: 23211 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 2B714DDD01 for ; Mon, 16 Feb 2009 18:46:01 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753974AbZBPHps (ORCPT ); Mon, 16 Feb 2009 02:45:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753962AbZBPHpr (ORCPT ); Mon, 16 Feb 2009 02:45:47 -0500 Received: from drevil.shawell.net ([86.54.240.115]:43423 "EHLO drevil2.shawell.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753776AbZBPHpr (ORCPT ); Mon, 16 Feb 2009 02:45:47 -0500 Received: from localhost.localdomain (kensington.shawell.net [10.0.20.15]) by drevil2.shawell.net (Postfix) with ESMTP id A82E437820; Mon, 16 Feb 2009 07:45:44 +0000 (GMT) From: Steve Glendinning To: netdev@vger.kernel.org Cc: Roel Kluin , Vlad Lyalikov , Ian Saturley , David Miller , Steve Glendinning Subject: [PATCH] smsc9420: fix another postfixed timeout Date: Mon, 16 Feb 2009 07:46:06 +0000 Message-Id: <1234770366-3572-1-git-send-email-steve.glendinning@smsc.com> X-Mailer: git-send-email 1.6.0.6 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Roel Kluin recently fixed several instances where variables reach -1, but 0 is tested afterwards. This patch fixes another, so the timeout will be correctly detected and a warning printed. Signed-off-by: Steve Glendinning --- drivers/net/smsc9420.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/smsc9420.c b/drivers/net/smsc9420.c index a1e4b38..83938e1 100644 --- a/drivers/net/smsc9420.c +++ b/drivers/net/smsc9420.c @@ -341,7 +341,7 @@ static int smsc9420_eeprom_send_cmd(struct smsc9420_pdata *pd, u32 op) do { msleep(1); e2cmd = smsc9420_reg_read(pd, E2P_CMD); - } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (timeout--)); + } while ((e2cmd & E2P_CMD_EPC_BUSY_) && (--timeout)); if (!timeout) { smsc_info(HW, "TIMED OUT");