From patchwork Sat Jan 17 16:47:12 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 19117 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 31538DE05C for ; Sun, 18 Jan 2009 03:47:29 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758989AbZAQQrX (ORCPT ); Sat, 17 Jan 2009 11:47:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758455AbZAQQrX (ORCPT ); Sat, 17 Jan 2009 11:47:23 -0500 Received: from smtp.wellnetcz.com ([212.24.148.102]:55728 "EHLO smtp.wellnetcz.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758060AbZAQQrW (ORCPT ); Sat, 17 Jan 2009 11:47:22 -0500 Received: from localhost.localdomain ([88.208.94.142]) by smtp.wellnetcz.com (8.14.1/8.14.1) with ESMTP id n0HH4QTq018584; Sat, 17 Jan 2009 18:04:27 +0100 From: Jiri Slaby To: davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby , Alexey Dobriyan Subject: [PATCH 1/1] NET: net_namespace, fix lock imbalance Date: Sat, 17 Jan 2009 17:47:12 +0100 Message-Id: <1232210832-30041-1-git-send-email-jirislaby@gmail.com> X-Mailer: git-send-email 1.6.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org register_pernet_gen_subsys omits mutex_unlock in one fail path. Fix it. Signed-off-by: Jiri Slaby Cc: David S. Miller Cc: Alexey Dobriyan --- net/core/net_namespace.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net/core/net_namespace.c b/net/core/net_namespace.c index 55cffad..55151fa 100644 --- a/net/core/net_namespace.c +++ b/net/core/net_namespace.c @@ -341,8 +341,8 @@ again: rv = register_pernet_operations(first_device, ops); if (rv < 0) ida_remove(&net_generic_ids, *id); - mutex_unlock(&net_mutex); out: + mutex_unlock(&net_mutex); return rv; } EXPORT_SYMBOL_GPL(register_pernet_gen_subsys);