From patchwork Fri Dec 19 18:05:29 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steve Glendinning X-Patchwork-Id: 14869 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id 27004DDED7 for ; Sat, 20 Dec 2008 05:05:41 +1100 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751833AbYLSSFe (ORCPT ); Fri, 19 Dec 2008 13:05:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751792AbYLSSFe (ORCPT ); Fri, 19 Dec 2008 13:05:34 -0500 Received: from [86.54.240.115] ([86.54.240.115]:40774 "EHLO drevil2.shawell.net" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751758AbYLSSFc (ORCPT ); Fri, 19 Dec 2008 13:05:32 -0500 Received: from localhost.localdomain (unknown [10.0.20.15]) by drevil2.shawell.net (Postfix) with ESMTP id C583937975; Fri, 19 Dec 2008 18:05:25 +0000 (GMT) From: Steve Glendinning To: netdev@vger.kernel.org Cc: dfoley@telus.net, Ian Saturley , Steve Glendinning Subject: [PATCH 1/2] smsc911x: don't clobber driver_data Date: Fri, 19 Dec 2008 18:05:29 +0000 Message-Id: <1229709930-19925-1-git-send-email-steve.glendinning@smsc.com> X-Mailer: git-send-email 1.6.0.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org smsc911x uses driver_data to store our net_device, don't overwrite this with the mii_bus. Reported and fixed by dfoley@telus.net. Signed-off-by: Steve Glendinning --- drivers/net/smsc911x.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/net/smsc911x.c b/drivers/net/smsc911x.c index fa28542..cd925de 100644 --- a/drivers/net/smsc911x.c +++ b/drivers/net/smsc911x.c @@ -822,7 +822,6 @@ static int __devinit smsc911x_mii_init(struct platform_device *pdev, pdata->mii_bus->irq[i] = PHY_POLL; pdata->mii_bus->parent = &pdev->dev; - dev_set_drvdata(&pdev->dev, &pdata->mii_bus); pdata->using_extphy = 0;