From patchwork Thu Nov 16 04:27:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 838403 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ZLBFlPD0"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ycpDT37QBz9s7G for ; Thu, 16 Nov 2017 15:29:29 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757688AbdKPE3Z (ORCPT ); Wed, 15 Nov 2017 23:29:25 -0500 Received: from mail-pg0-f66.google.com ([74.125.83.66]:49985 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756328AbdKPE2z (ORCPT ); Wed, 15 Nov 2017 23:28:55 -0500 Received: by mail-pg0-f66.google.com with SMTP id 70so7187246pgf.6; Wed, 15 Nov 2017 20:28:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=LGg+QPPj67kt0zlEKQf9Z1xyoFzCEl02BtdUEIPIpRc=; b=ZLBFlPD05Io7VEwo5mV1+XRL3Im1b+QTms+ZU3hqUHsUajmYgD2bf+x2dihBiWZGLy ca0TXc0rl4R33c8fyG9ebIHEimxoornvoTUMfSLAsELu3TDfgvpaVXgH3kBLY/6Q/PtA BbVMKqjduaJ5cp9kqi4VeY0DkXUYm6QPpuqS9CSB0OWhW62IVWfjcPUP92FcnViJReE4 tq6ANc+dnHPVwBQT396HW07FzYe5czleXzh5cLLgG8bAJ5m2hgfG63JkCJFXcxHrVEY1 uKjqE6m/TEA04HXEkH8jy7FFF8pjGzJ+WEDTZZlsbw0yudos9zvHrOF9he34cQctCoMX gayw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=LGg+QPPj67kt0zlEKQf9Z1xyoFzCEl02BtdUEIPIpRc=; b=MjpwJEPm1rI/1Ba8AkSWGlRA1XVEzSIn60xHAINAkiaV3T4pVk/730BqNMHnJR+TfQ mHh2Qsgt8PAMEf4tEF1N71iN3Yw3KnVLuojXI6Wyeo42VnvwIzLIRmoOcEA/sA1MzrFO ltDCDfm8xeWoJRjhO3PuPiE14iOfllosIRayDfK9fw2mGaOeC16yOCG70xq9lWazIBAc eTXHrBa07v0x2MmdJKhvnrCICeCwAQ5wxn85nWEXfIvknu5b4uMDCcrlDDUa8Zh+e8sp j0+NzKOPM3CWB06q/f425ueg8zJEeD9SODkrT5jPdAhmfD/shq6hxHypEKpTJbVNQonr 1woA== X-Gm-Message-State: AJaThX5hgvwTDKfQv0mZOA7nIYpLyjnUuxLvzLSTkK/EIn4BlgDypkoR wlJLf7OkKezrw5wFn7k+gR8bwg== X-Google-Smtp-Source: AGs4zMZvJm0qo//1YzfUK0v1p5Y8tBKBFc+DTlJR2yeFC+Gx/7S37hgc6HIqcKGwJOiRkHCUzlwDRQ== X-Received: by 10.99.3.146 with SMTP id 140mr399551pgd.275.1510806534445; Wed, 15 Nov 2017 20:28:54 -0800 (PST) Received: from symbol-HP-Z420-Workstation.zebra.lan ([223.31.70.102]) by smtp.googlemail.com with ESMTPSA id m69sm421965pfc.27.2017.11.15.20.28.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 15 Nov 2017 20:28:53 -0800 (PST) From: Arvind Yadav To: isdn@linux-pingi.de, davem@davemloft.net, stephen@networkplumber.org, johannes.berg@intel.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 01/12] isdn: hisax: Fix pnp_irq's error checking for setup_asuscom Date: Thu, 16 Nov 2017 09:57:18 +0530 Message-Id: <1103d4f44048f944961fbab0fbc16131c7f54d23.1510805781.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: References: In-Reply-To: References: Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The pnp_irq() function returns -1 if an error occurs. pnp_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- drivers/isdn/hisax/asuscom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/isdn/hisax/asuscom.c b/drivers/isdn/hisax/asuscom.c index 62f9c43..74c8714 100644 --- a/drivers/isdn/hisax/asuscom.c +++ b/drivers/isdn/hisax/asuscom.c @@ -348,7 +348,7 @@ int setup_asuscom(struct IsdnCard *card) } card->para[1] = pnp_port_start(pnp_d, 0); card->para[0] = pnp_irq(pnp_d, 0); - if (!card->para[0] || !card->para[1]) { + if (card->para[0] == -1 || !card->para[1]) { printk(KERN_ERR "AsusPnP:some resources are missing %ld/%lx\n", card->para[0], card->para[1]); pnp_disable_dev(pnp_d);