| Message ID | 0de52d891d7925b02f4f0fe2c750d076e55434d9.1562734889.git.joe@perches.com |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | David Miller |
| Headers | show |
| Series | treewide: Fix GENMASK misuses | expand |
> Subject: [PATCH 09/12] rtw88: Fix misuse of GENMASK macro > > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches <joe@perches.com> > --- > drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c > b/drivers/net/wireless/realtek/rtw88/rtw8822b.c > index 1172f6c0605b..d61d534396c7 100644 > --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c > +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c > @@ -997,7 +997,7 @@ static void rtw8822b_do_iqk(struct rtw_dev *rtwdev) > rtw_write_rf(rtwdev, RF_PATH_A, RF_DTXLOK, RFREG_MASK, 0x0); > > reload = !!rtw_read32_mask(rtwdev, REG_IQKFAILMSK, BIT(16)); > - iqk_fail_mask = rtw_read32_mask(rtwdev, REG_IQKFAILMSK, > GENMASK(0, 7)); > + iqk_fail_mask = rtw_read32_mask(rtwdev, REG_IQKFAILMSK, > GENMASK(7, 0)); > rtw_dbg(rtwdev, RTW_DBG_PHY, > "iqk counter=%d reload=%d do_iqk_cnt=%d > n_iqk_fail(mask)=0x%02x\n", > counter, reload, ++do_iqk_cnt, iqk_fail_mask); > -- That's correct. Thanks. Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com> Yan-Hsuan
Joe Perches <joe@perches.com> wrote: > Arguments are supposed to be ordered high then low. > > Signed-off-by: Joe Perches <joe@perches.com> > Acked-by: Yan-Hsuan Chuang <yhchuang@realtek.com> Patch applied to wireless-drivers-next.git, thanks. 5ff29d836d1b rtw88: Fix misuse of GENMASK macro
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822b.c b/drivers/net/wireless/realtek/rtw88/rtw8822b.c index 1172f6c0605b..d61d534396c7 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822b.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822b.c @@ -997,7 +997,7 @@ static void rtw8822b_do_iqk(struct rtw_dev *rtwdev) rtw_write_rf(rtwdev, RF_PATH_A, RF_DTXLOK, RFREG_MASK, 0x0); reload = !!rtw_read32_mask(rtwdev, REG_IQKFAILMSK, BIT(16)); - iqk_fail_mask = rtw_read32_mask(rtwdev, REG_IQKFAILMSK, GENMASK(0, 7)); + iqk_fail_mask = rtw_read32_mask(rtwdev, REG_IQKFAILMSK, GENMASK(7, 0)); rtw_dbg(rtwdev, RTW_DBG_PHY, "iqk counter=%d reload=%d do_iqk_cnt=%d n_iqk_fail(mask)=0x%02x\n", counter, reload, ++do_iqk_cnt, iqk_fail_mask);
Arguments are supposed to be ordered high then low. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/net/wireless/realtek/rtw88/rtw8822b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)