Message ID | 00a601d24ab6$4e9274d0$ebb75e70$@asix.com.tw |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Hi Allan, On 30/11/16 03:03, ASIX_Allan [Office] wrote: > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when suspending > - Need to restart MII when restoring PHY > > Signed-off-by: Allan Chou <allan@asix.com.tw> > Signed-off-by: Robert Foss <robert.foss@collabora.com> > Tested-by: Robert Foss <robert.foss@collabora.com> > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Tested-by: Allan Chou <allan@asix.com.tw> V3 of this patch is already in the current mainline branch. So you need to send a patch on top of V3 (or v4.9-rc7) to get this fixed. Also you should highlight the fact that this is a fix needed for v4.9. Cheers Jon
Dear Jon, Thanks a lot for your reminding. I will submit a new driver patch soon. --- Best regards, Allan Chou -----Original Message----- From: Jon Hunter [mailto:jonathanh@nvidia.com] Sent: Wednesday, November 30, 2016 4:08 PM To: allan@asix.com.tw; freddy@asix.com.tw; Dean_Jenkins@mentor.com; Mark_Craske@mentor.com; davem@davemloft.net; robert.foss@collabora.com; ivecera@redhat.com; john.stultz@linaro.org; vpalatin@chromium.org; stephen@networkplumber.org; grundler@chromium.org; changchias@gmail.com; andrew@lunn.ch; tremyfr@gmail.com; colin.king@canonical.com; linux-usb@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; vpalatin@google.com Subject: Re: [PATCH v4 3/5] net: asix: Fix AX88772x resume failures Hi Allan, On 30/11/16 03:03, ASIX_Allan [Office] wrote: > The change fixes AX88772x resume failure by > - Restore incorrect AX88772A PHY registers when resetting > - Need to stop MAC operation when suspending > - Need to restart MII when restoring PHY > > Signed-off-by: Allan Chou <allan@asix.com.tw> > Signed-off-by: Robert Foss <robert.foss@collabora.com> > Tested-by: Robert Foss <robert.foss@collabora.com> > Tested-by: Jon Hunter <jonathanh@nvidia.com> > Tested-by: Allan Chou <allan@asix.com.tw> V3 of this patch is already in the current mainline branch. So you need to send a patch on top of V3 (or v4.9-rc7) to get this fixed. Also you should highlight the fact that this is a fix needed for v4.9. Cheers Jon -- nvpublic
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c index ebeb730..083dc2e 100644 --- a/drivers/net/usb/asix_devices.c +++ b/drivers/net/usb/asix_devices.c @@ -35,6 +35,15 @@ #define PHY_MODE_RTL8211CL 0x000C +#define AX88772A_PHY14H 0x14 +#define AX88772A_PHY14H_DEFAULT 0x442C + +#define AX88772A_PHY15H 0x15 +#define AX88772A_PHY15H_DEFAULT 0x03C8 + +#define AX88772A_PHY16H 0x16 +#define AX88772A_PHY16H_DEFAULT 0x4044 + struct ax88172_int_data { __le16 res1; u8 link; @@ -424,7 +433,7 @@ static int ax88772a_hw_reset(struct usbnet *dev, int in_pm) { struct asix_data *data = (struct asix_data *)&dev->data; int ret, embd_phy; - u16 rx_ctl; + u16 rx_ctl, phy14h, phy15h, phy16h; u8 chipcode = 0; ret = asix_write_gpio(dev, AX_GPIO_RSE, 5, in_pm); @@ -482,6 +491,32