From patchwork Thu Nov 12 17:45:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Abeni X-Patchwork-Id: 1399151 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=RWnJZaBy; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4CX8D637ygz9sPB for ; Fri, 13 Nov 2020 04:46:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbgKLRq1 (ORCPT ); Thu, 12 Nov 2020 12:46:27 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34001 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbgKLRq1 (ORCPT ); Thu, 12 Nov 2020 12:46:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605203186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=KfbWGUuCzLgBWD+bbt6bFT/H+lwpvPHLlvbYkqXPlAo=; b=RWnJZaByXb35M74FzYLwg6Eh3LNvBfipxWy9K97KOwovxdb8K8sk5QCEehWCqV+rUk1w07 Q23fwX9mZAT2JZ2NVhlnIRr4hyxp1XR1J7Us2xXAcQ2cIcoSZQFNqllQk5pQe3dEixJOMe xBx8gr1eFJfrQBy/7vGlT5cMAUkNCVw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-PNadXp2hOkeXYkkh7GGf7Q-1; Thu, 12 Nov 2020 12:46:23 -0500 X-MC-Unique: PNadXp2hOkeXYkkh7GGf7Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29059809DF3; Thu, 12 Nov 2020 17:46:22 +0000 (UTC) Received: from gerbillo.redhat.com (ovpn-112-208.ams2.redhat.com [10.36.112.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7B4505578C; Thu, 12 Nov 2020 17:46:19 +0000 (UTC) From: Paolo Abeni To: netdev@vger.kernel.org Cc: Eric Dumazet , mptcp@lists.01.org, Jakub Kicinski Subject: [PATCH net-next v2 00/13] mptcp: improve multiple xmit streams support Date: Thu, 12 Nov 2020 18:45:20 +0100 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This series improves MPTCP handling of multiple concurrent xmit streams. The to-be-transmitted data is enqueued to a subflow only when the send window is open, keeping the subflows xmit queue shorter and allowing for faster switch-over. The above requires a more accurate msk socket state tracking and some additional infrastructure to allow pushing the data pending in the msk xmit queue as soon as the MPTCP's send window opens (patches 6-10). As a side effect, the MPTCP socket could enqueue data to subflows after close() time - to completely spooling the data sitting in the msk xmit queue. Dealing with the requires some infrastructure and core TCP changes (patches 1-5) Finally, patches 11-12 introduce a more accurate tracking of the other end's receive window. Overall this refactor the MPTCP xmit path, without introducing new features - the new code is covered by the existing self-tests. v1 -> v2: - this is just a report, to cope with patchwork issues, no changes at all Florian Westphal (2): mptcp: rework poll+nospace handling mptcp: keep track of advertised windows right edge Paolo Abeni (11): tcp: factor out tcp_build_frag() mptcp: use tcp_build_frag() tcp: factor out __tcp_close() helper mptcp: introduce mptcp_schedule_work mptcp: reduce the arguments of mptcp_sendmsg_frag mptcp: add accounting for pending data mptcp: introduce MPTCP snd_nxt mptcp: refactor shutdown and close mptcp: move page frag allocation in mptcp_sendmsg() mptcp: try to push pending data on snd una updates mptcp: send explicit ack on delayed ack_seq incr include/net/tcp.h | 4 + net/ipv4/tcp.c | 128 +++--- net/mptcp/options.c | 30 +- net/mptcp/pm.c | 3 +- net/mptcp/pm_netlink.c | 6 +- net/mptcp/protocol.c | 969 ++++++++++++++++++++++++----------------- net/mptcp/protocol.h | 72 ++- net/mptcp/subflow.c | 33 +- 8 files changed, 758 insertions(+), 487 deletions(-)