mbox series

[net-next,0/2] net: stmmac: Enable Flow Control

Message ID cover.1555486210.git.joabreu@synopsys.com
Headers show
Series net: stmmac: Enable Flow Control | expand

Message

Jose Abreu April 17, 2019, 7:33 a.m. UTC 
I don't know of any specific reason why Flow Control is off by default but
do let me know if there is any.

Tested in B2B between XGMAC2 and GMAC5.

Cc: Joao Pinto <jpinto@synopsys.com>
Cc: David S. Miller <davem@davemloft.net>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>

Jose Abreu (2):
  net: stmmac: dwxgmac: Finish the Flow Control implementation
  net: stmmac: Set Flow Control to automatic mode in the driver

 drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h     |  5 +++
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c | 46 ++++++++++++++++++++++
 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c  |  2 +-
 3 files changed, 52 insertions(+), 1 deletion(-)

Comments

David Miller April 17, 2019, 5:14 p.m. UTC | #1 
From: Jose Abreu <Jose.Abreu@synopsys.com>
Date: Wed, 17 Apr 2019 09:33:03 +0200

> I don't know of any specific reason why Flow Control is off by default but
> do let me know if there is any.
> 
> Tested in B2B between XGMAC2 and GMAC5.
> 
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>

I'm just going to apply this series now, it's easy to revert if necessary.

Thanks.
Aaro Koskinen April 17, 2019, 6:01 p.m. UTC | #2 
Hi,

On Wed, Apr 17, 2019 at 09:33:03AM +0200, Jose Abreu wrote:
> I don't know of any specific reason why Flow Control is off by default but
> do let me know if there is any.

It seems dwmac1000 assumes 4K FIFO size when configuring threshold
values. This could be non-optimal for 8K/16K FIFOs, but that can be
fixed later on with incremental patches.

A.