mbox series

[iproute2,0/3] l2tp: remove unused fields in struct l2tp_parm

Message ID cover.1532685939.git.g.nault@alphalink.fr
Headers show
Series l2tp: remove unused fields in struct l2tp_parm | expand

Message

Guillaume Nault July 27, 2018, 10:26 a.m. UTC
Several fields of struct l2tp_parm are handled by create_session() but
can't actually be set by user.
Most of these fields can also be set by get_response(), but are ignored
afterwards.

Since these fields can't have any visible effect, let's just remove
them.

Guillaume Nault (3):
  l2tp: drop data_seq
  l2tp: drop mtu
  l2tp: drop lns_mode

 ip/ipl2tp.c | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Stephen Hemminger July 27, 2018, 2:57 p.m. UTC | #1
On Fri, 27 Jul 2018 12:26:28 +0200
Guillaume Nault <g.nault@alphalink.fr> wrote:

> Several fields of struct l2tp_parm are handled by create_session() but
> can't actually be set by user.
> Most of these fields can also be set by get_response(), but are ignored
> afterwards.
> 
> Since these fields can't have any visible effect, let's just remove
> them.
> 
> Guillaume Nault (3):
>   l2tp: drop data_seq
>   l2tp: drop mtu
>   l2tp: drop lns_mode
> 
>  ip/ipl2tp.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 

These make sense for iproute2 next
Guillaume Nault July 27, 2018, 3:15 p.m. UTC | #2
On Fri, Jul 27, 2018 at 07:57:12AM -0700, Stephen Hemminger wrote:
> On Fri, 27 Jul 2018 12:26:28 +0200
> Guillaume Nault <g.nault@alphalink.fr> wrote:
> 
> > Several fields of struct l2tp_parm are handled by create_session() but
> > can't actually be set by user.
> > Most of these fields can also be set by get_response(), but are ignored
> > afterwards.
> > 
> > Since these fields can't have any visible effect, let's just remove
> > them.
> > 
> > Guillaume Nault (3):
> >   l2tp: drop data_seq
> >   l2tp: drop mtu
> >   l2tp: drop lns_mode
> > 
> >  ip/ipl2tp.c | 13 -------------
> >  1 file changed, 13 deletions(-)
> > 
> 
> These make sense for iproute2 next
These patches haven't been rejected in patchwork. Does that mean that
David A. will pick them up? Or should I repost to iproute2-next anyway?