From patchwork Wed Jun 13 13:09:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 928873 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=alphalink.fr Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 415Rsz5gqkz9s0W for ; Wed, 13 Jun 2018 23:09:26 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935617AbeFMNJX (ORCPT ); Wed, 13 Jun 2018 09:09:23 -0400 Received: from zimbra.alphalink.fr ([217.15.80.77]:56029 "EHLO zimbra.alphalink.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935575AbeFMNJU (ORCPT ); Wed, 13 Jun 2018 09:09:20 -0400 Received: from localhost (localhost [127.0.0.1]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id 5B9622B52122; Wed, 13 Jun 2018 15:09:18 +0200 (CEST) Received: from zimbra.alphalink.fr ([127.0.0.1]) by localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id YMIXDzox2qEr; Wed, 13 Jun 2018 15:09:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id 2B0AC2B52120; Wed, 13 Jun 2018 15:09:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mail-2-cbv2.admin.alphalink.fr Received: from zimbra.alphalink.fr ([127.0.0.1]) by localhost (mail-2-cbv2.admin.alphalink.fr [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id o9HKNOOfNgWU; Wed, 13 Jun 2018 15:09:17 +0200 (CEST) Received: from c-dev-0.admin.alphalink.fr (94-84-15-217.reverse.alphalink.fr [217.15.84.94]) by mail-2-cbv2.admin.alphalink.fr (Postfix) with ESMTP id 02FB92B5202D; Wed, 13 Jun 2018 15:09:17 +0200 (CEST) Received: by c-dev-0.admin.alphalink.fr (Postfix, from userid 1000) id D6701601D5; Wed, 13 Jun 2018 15:09:16 +0200 (CEST) Date: Wed, 13 Jun 2018 15:09:16 +0200 From: Guillaume Nault To: netdev@vger.kernel.org Cc: James Chapman Subject: [PATCH net 0/4] l2tp: pppol2tp_connect() fixes Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Mutt-Fcc: =Sent User-Agent: Mutt/1.10.0 (2018-05-17) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This series fixes a few remaining issues with pppol2tp_connect(). It doesn't try to prevent invalid configurations that have no effect on kernel's reliability. That would be work for a future patch set. Patch 2 is the most important as it avoids an invalid pointer dereference crashing the kernel. It depends on patch 1 for correctly identifying L2TP session types. Patches 3 and 4 avoid creating stale tunnels and sessions. Guillaume Nault (4): l2tp: fix pseudo-wire type for sessions created by pppol2tp_connect() l2tp: only accept PPP sessions in pppol2tp_connect() l2tp: prevent pppol2tp_connect() from creating kernel sockets l2tp: clean up stale tunnel or session in pppol2tp_connect's error path net/l2tp/l2tp_ppp.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)