[v3,0/4] rtlwifi: Fix issues with rtl8723ae

Message ID	DB7PR07MB535370C263EDDF8112ED81E8E4880@DB7PR07MB5353.eurprd07.prod.outlook.com
Headers	show Return-Path: <netdev-owner@vger.kernel.org> From: Bernd Edlinger <bernd.edlinger@hotmail.de> To: Ping-Ke Shih <pkshih@realtek.com>, Larry Finger <Larry.Finger@lwfinger.net>, Kalle Valo <kvalo@codeaurora.org>, "David S. Miller" <davem@davemloft.net>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Andrew Lunn <andrew@lunn.ch> Subject: [PATCH v3 0/4] rtlwifi: Fix issues with rtl8723ae Thread-Topic: [PATCH v3 0/4] rtlwifi: Fix issues with rtl8723ae Thread-Index: AQHUpVMOhOTwyJzVpEik1aol4KfSfQ== Date: Sun, 6 Jan 2019 00:02:05 +0000 Message-ID: <DB7PR07MB535370C263EDDF8112ED81E8E4880@DB7PR07MB5353.eurprd07.prod.outlook.com> Accept-Language: en-US, en-GB, de-DE Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <C3F36AC084F87D4DA7F1489AAF178201@eurprd07.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk
Series	rtlwifi: Fix issues with rtl8723ae \| expand [v3,0/4] rtlwifi: Fix issues with rtl8723ae [v3,1/4] rtl8723ae: Take the FW LPS mode handling out [v3,2/4] rtl8723ae: Dont use old data for input gain control [v3,3/4] rtl8723ae: Re-introduce the adaptive rate control [v3,4/4] rtlwifi: Don't clear num_rx_inperiod too early

Message ID

DB7PR07MB535370C263EDDF8112ED81E8E4880@DB7PR07MB5353.eurprd07.prod.outlook.com

Headers

From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Ping-Ke Shih <pkshih@realtek.com>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Kalle Valo <kvalo@codeaurora.org>,
	"David S. Miller" <davem@davemloft.net>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH v3 0/4] rtlwifi: Fix issues with rtl8723ae
Thread-Topic: [PATCH v3 0/4] rtlwifi: Fix issues with rtl8723ae
Thread-Index: AQHUpVMOhOTwyJzVpEik1aol4KfSfQ==
Date: Sun, 6 Jan 2019 00:02:05 +0000
Message-ID: <DB7PR07MB535370C263EDDF8112ED81E8E4880@DB7PR07MB5353.eurprd07.prod.outlook.com>
Accept-Language: en-US, en-GB, de-DE
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [NFImcgpbZSiC6tZdNMtNUWnYTS+9UHrF]
x-microsoft-original-message-id: <f3655c8f-7ac7-275a-e974-48a56463ba4d@hotmail.de>
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1; HE1EUR01HT212;
	6:AcVB3CzA0c38ydNE2r8DlU+1jWOyXirVjZ2vDi16T880HgOnHgLU1HX2aeg0XCAOt/V1FXwz2LUDIiUGjOCJJS4ZpZj4wcBi0uURfWZMD/j+LAMmdp+ccCwdx4kUmEtZt7nyaDIpKwFp6xA0BDVzJj03CKfeWDNm8v1xYJFCC2n13bHSgifgnXhisMpjNUYJ1P7WKeeaK28XLA6Ks4fXs/qyZACMbgJ5xTSFu1iOnEVzJP8mvhmei+4r1RIxhgyGm2c+vwGRMBXubUczLrqOzRsqtUytSdnSVjoBNkkU0DlJlz7MQsOzLt+ocbTDzwUesRqiHXAjRxfIZhSftfHaN9kXJR13WAP+q/UGQji8Vg/DYR8YbNDi791XKTQbwAME0F1g5H3MiMCowjGep/S+fWV1yd8jRVqR1YsW2bmXTce5vlnmYhEkiAcWLabfbcKae4R6Wwfq/X8hi3ps5oMAYA==;
	5:qisw0UCSd+Wi8V+O6SbFjxgNtHYK2+ruFprVSBe1lpYDTPKD8zdLOfkiKs5Y5GcFODgQGUGJ9TwJ4pxJy+6nXbh0MLd/uCZYt9BjUvu6bI5gojgfLWdX5Hkxu63UenYOC1PPF3M78JcJS9lvdfDToJBRXSfuR3oJDUFHgJ2/uZc=;
	7:tqBbIvvg297Fjn3/0LVoZP+Cl+g/5QSVwl8/IyPcmDClTbIBFIIA/rbZLRRNcqFYP3varbdYLXQAy01UFgXLphkWOzDcCmjYjqiKAsLthBCXWGhKseuMCVu/YGbyFCOW6ajQ6LNtPuiKOLcwGv8eGw==
x-incomingheadercount: 62
x-eopattributedmessage: 0
x-microsoft-antispam: BCL:0; PCL:0;
	RULEID:(2390118)(7020095)(201702061078)(5061506573)(5061507331)(1603103135)(2017031320274)(2017031324274)(2017031323274)(2017031322404)(1601125500)(1603101475)(1701031045);
	SRVR:HE1EUR01HT212; 
x-ms-traffictypediagnostic: HE1EUR01HT212:
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(4566010)(82015058);
	SRVR:HE1EUR01HT212; BCL:0; PCL:0; RULEID:; SRVR:HE1EUR01HT212;
x-microsoft-antispam-message-info: QRXXc88hs7A2YnAXfQQQjK8pgYShx3ZmjytubL3e1TJ758L/x4+2mJwRAHyTMcsp
Content-Type: text/plain; charset="utf-8"
Content-ID: <C3F36AC084F87D4DA7F1489AAF178201@eurprd07.prod.outlook.com>
Content-Transfer-Encoding: base64
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: d4d70346-2c10-4f39-8c00-e767963926d9
X-MS-Exchange-CrossTenant-Network-Message-Id: 1affd2c0-22f0-4517-9eb6-08d6736a313e
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: d4d70346-2c10-4f39-8c00-e767963926d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2019 00:02:04.5043
	(UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT212
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

Series

rtlwifi: Fix issues with rtl8723ae | expand

Message

Bernd Edlinger Jan. 6, 2019, 12:02 a.m. UTC

Currently the rtl8723ae driver is broken (since v4.7).

Connection to AP is lost very often, especially when
the signal level is not very good.

The main issue is the power save mode is basically
not working, and seems to trigger a firmware bug.
So I had to take out the FW LPS mode handling.

While debugging the driver I found a couple related issues,
for instance that the signal level in dm.undec_sm_pwdb
is no longer accurate (may be even much too high) when no more
packets are received, and it increases the likelihood to receive
something if the input gain is set to maximum.

The patch was tested with the rtl8723ae PCI card in my laptop
against a FRITZ!Box 7590 AP -- the WiFi connection works now
very reliable for me.

ChangeLog:

v2: Adjusts the defaults of swlps and fwlps module
parameters to match the firmware capabilities instead of removing
the whole code, so it can be easily re-activated once a firmware
update is available.

v3: Make the title of each patch fit in one line.


Bernd Edlinger (4):
  rtl8723ae: Take the FW LPS mode handling out
  rtl8723ae: Dont use old data for input gain control
  rtl8723ae: Re-introduce the adaptive rate control
  rtlwifi: Don't clear num_rx_inperiod too early 

 drivers/net/wireless/realtek/rtlwifi/base.c        |  4 +-
 drivers/net/wireless/realtek/rtlwifi/core.c        |  2 +
 .../net/wireless/realtek/rtlwifi/rtl8723ae/dm.c    | 95 +++++++++++++++++++++-
 .../net/wireless/realtek/rtlwifi/rtl8723ae/sw.c    |  8 +-
 4 files changed, 101 insertions(+), 8 deletions(-)