mbox series

[net-next,v5,0/6] 8390: core cleanups

Message ID 20200914210128.7741-1-W_Armin@gmx.de
Headers show
Series 8390: core cleanups | expand

Message

Armin Wolf Sept. 14, 2020, 9:01 p.m. UTC 
The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c

While most changes are coding style related,
pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.

Other functional changes include the removal of
version-printing in lib8390.c so modules using lib8390.c
do not need a global version-string in order to compile
successfully.

Patches do compile and run flawless on 5.9.0-rc3 with
a RTL8029AS nic using ne2k-pci.

v5 changes:
- sort includes
- do not realign comments
- move pr_cont() -> netdev_err() change to separate patch
- remove unused DRV_RELDATA and DRV_NAME
- break 8390.c changes into separate patches

v4 changes:
- remove unused version string to prevent warnings

v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c

v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c

Armin Wolf (6):
  lib8390: Fix coding style issues and remove version printing
  lib8390: Replace pr_cont() with SMP-safe construct
  8390: Replace version string with MODULE_* macros
  8390: Include necessary libraries
  8390: Fix coding style issues
  8390: Remove version string

 drivers/net/ethernet/8390/8390.c      |  18 +-
 drivers/net/ethernet/8390/8390p.c     |  15 +-
 drivers/net/ethernet/8390/ax88796.c   |   3 -
 drivers/net/ethernet/8390/etherh.c    |   3 -
 drivers/net/ethernet/8390/hydra.c     |   7 +-
 drivers/net/ethernet/8390/lib8390.c   | 433 ++++++++++++--------------
 drivers/net/ethernet/8390/mac8390.c   |   3 -
 drivers/net/ethernet/8390/mcf8390.c   |   3 -
 drivers/net/ethernet/8390/xsurf100.c  |   3 -
 drivers/net/ethernet/8390/zorro8390.c |   5 +-
 10 files changed, 232 insertions(+), 261 deletions(-)

--
2.20.1

Comments

David Miller Sept. 14, 2020, 9:14 p.m. UTC | #1 
From: Armin Wolf <W_Armin@gmx.de>
Date: Mon, 14 Sep 2020 23:01:22 +0200

> The purpose of this patchset is to do some
> cleanups in lib8390.c and 8390.c

A lot of these changes are borderline beneficial, at best.

You are adding include files to foo.c files that are already included
by lib8390.c already (which the foo.c file includes).  This is
redundant and makes the compiler work harder.  lib8390.c is
designed to work like this.

Your first patch mixes comment formatting with actual code
changes (adding new curly braces and such).

And so on and so forth...

I honestly don't like this patch series at all.

If you were about to add a big new feature to the 8390 code
and wanted to clean it up first before doing so, maybe I'd
be ok with these changes.  But as a pure cleanup, sorry I'm
not going to apply this stuff.