mbox series

[0/3,v4,net-next] 8390: core cleanups

Message ID 20200905174156.GA5838@mx-linux-amd
Headers show
Series 8390: core cleanups | expand

Message

Armin Wolf Sept. 5, 2020, 5:41 p.m. UTC 
The purpose of this patchset is to do some
cleanups in lib8390.c and 8390.c.

While most changes are coding-style related,
pr_cont() usage in lib8390.c was replaced by
a more SMP-safe construct.

Other functional changes include the removal of
version-printing in lib8390.c so modules using lib8390.c
do not need a global version-string in order to compile
successfully.

Patches do compile and run flawless on 5.9.0-rc1 with
a RTL8029AS nic using ne2k-pci.

v4 changes:
- Remove unused version strings to prevent warnings

v3 changes:
- swap commits to not break buildability (sorry)
- move MODULE_LICENCE at the bottom and remove MODULE_VERSION in 8390.c

v2 changes:
- change "librarys" to "libraries" in 8390.c commit
- improve 8390.c commit
- prevent uneven whitespaces in error message (lib8390.c)
- do not destroy kernel doc comments in lib8390.c
- fix some typos in lib8390.c

Armin Wolf (3):
  lib8390: Fix coding-style issues and remove verion printing
  8390: Miscellaneous cleanups
  8390: Remove version string

 drivers/net/ethernet/8390/8390.c      |  21 +-
 drivers/net/ethernet/8390/8390p.c     |  18 +-
 drivers/net/ethernet/8390/ax88796.c   |   3 -
 drivers/net/ethernet/8390/etherh.c    |   3 -
 drivers/net/ethernet/8390/hydra.c     |   8 +-
 drivers/net/ethernet/8390/lib8390.c   | 590 +++++++++++++-------------
 drivers/net/ethernet/8390/mac8390.c   |   3 -
 drivers/net/ethernet/8390/mcf8390.c   |   3 -
 drivers/net/ethernet/8390/xsurf100.c  |   3 -
 drivers/net/ethernet/8390/zorro8390.c |   5 +-
 10 files changed, 332 insertions(+), 325 deletions(-)

--
2.20.1