mbox series

[net-next,0/7] ipv4: nexthop: Various improvements

Message ID 20200826164857.1029764-1-idosch@idosch.org
Headers show
Series ipv4: nexthop: Various improvements | expand

Message

Ido Schimmel Aug. 26, 2020, 4:48 p.m. UTC
From: Ido Schimmel <idosch@nvidia.com>

This patch set contains various improvements that I made to the nexthop
object code while studying it towards my upcoming changes.

While patches #4 and #6 fix bugs, they are not regressions (never
worked). They also do not occur to me as critical issues, which is why I
am targeting them at net-next.

Tested with fib_nexthops.sh:

Tests passed: 134
Tests failed:   0

Ido Schimmel (7):
  ipv4: nexthop: Reduce allocation size of 'struct nh_group'
  ipv4: nexthop: Use nla_put_be32() for NHA_GATEWAY
  ipv4: nexthop: Remove unnecessary rtnl_dereference()
  ipv4: nexthop: Correctly update nexthop group when removing a nexthop
  selftests: fib_nexthops: Test IPv6 route with group after removing
    IPv4 nexthops
  ipv4: nexthop: Correctly update nexthop group when replacing a nexthop
  selftests: fib_nexthops: Test IPv6 route with group after replacing
    IPv4 nexthops

 net/ipv4/nexthop.c                          | 49 ++++++++++++++++++---
 tools/testing/selftests/net/fib_nexthops.sh | 30 +++++++++++++
 2 files changed, 72 insertions(+), 7 deletions(-)

Comments

David Ahern Aug. 26, 2020, 7:18 p.m. UTC | #1
On 8/26/20 10:48 AM, Ido Schimmel wrote:
> While patches #4 and #6 fix bugs, they are not regressions (never
> worked). They also do not occur to me as critical issues, which is why I
> am targeting them at net-next.

I agree. Thanks for the work on this.
David Miller Aug. 26, 2020, 11:03 p.m. UTC | #2
From: Ido Schimmel <idosch@idosch.org>
Date: Wed, 26 Aug 2020 19:48:50 +0300

> This patch set contains various improvements that I made to the nexthop
> object code while studying it towards my upcoming changes.
> 
> While patches #4 and #6 fix bugs, they are not regressions (never
> worked). They also do not occur to me as critical issues, which is why I
> am targeting them at net-next.
> 
> Tested with fib_nexthops.sh:
> 
> Tests passed: 134
> Tests failed:   0

Series applied, thanks Ido.