mbox series

[net-next,0/2] devlink fixes for port and reporter field access

Message ID 20200821191221.82522-1-parav@mellanox.com
Headers show
Series devlink fixes for port and reporter field access | expand

Message

Parav Pandit Aug. 21, 2020, 7:12 p.m. UTC 
From: Parav Pandit <parav@nvidia.com>

Hi Dave,

These series contains two small fixes of devlink.

Patch-1 initializes port reporter fields early enough to
avoid access before initialized error.
Patch-2 protects port list lock during traversal.

Parav Pandit (2):
  devlink: Fix per port reporter fields initialization
  devlink: Protect devlink port list traversal

 net/core/devlink.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski Aug. 24, 2020, 8:48 p.m. UTC | #1 
On Fri, 21 Aug 2020 22:12:19 +0300 Parav Pandit wrote:
> From: Parav Pandit <parav@nvidia.com>
> 
> Hi Dave,
> 
> These series contains two small fixes of devlink.
> 
> Patch-1 initializes port reporter fields early enough to
> avoid access before initialized error.
> Patch-2 protects port list lock during traversal.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Why did you tag this for net-next, instead of net?
David Miller Aug. 24, 2020, 11:03 p.m. UTC | #2 
From: Parav Pandit <parav@mellanox.com>
Date: Fri, 21 Aug 2020 22:12:19 +0300

> These series contains two small fixes of devlink.
> 
> Patch-1 initializes port reporter fields early enough to
> avoid access before initialized error.
> Patch-2 protects port list lock during traversal.

Series applied, thank you.
Parav Pandit Aug. 25, 2020, 8:10 p.m. UTC | #3 
> From: netdev-owner@vger.kernel.org <netdev-owner@vger.kernel.org>
> On Behalf Of Jakub Kicinski
> 
> On Fri, 21 Aug 2020 22:12:19 +0300 Parav Pandit wrote:
> > From: Parav Pandit <parav@nvidia.com>
> >
> > Hi Dave,
> >
> > These series contains two small fixes of devlink.
> >
> > Patch-1 initializes port reporter fields early enough to avoid access
> > before initialized error.
> > Patch-2 protects port list lock during traversal.
> 
> Reviewed-by: Jakub Kicinski <kuba@kernel.org>
> 
> Why did you tag this for net-next, instead of net?
My bad. I will take care for subsequent fixes to tag for net.