mbox series

[net,0/3] ethtool-netlink bug fixes

Message ID 20200814131627.32021-1-maximmi@mellanox.com
Headers show
Series ethtool-netlink bug fixes | expand

Message

Maxim Mikityanskiy Aug. 14, 2020, 1:16 p.m. UTC 
This series contains a few bug fixes for ethtool-netlink. These bugs are
specific for the netlink interface, and the legacy ioctl interface is
not affected. These patches aim to have the same behavior in
ethtool-netlink as in the legacy ethtool.

Please also see the sibling series for the userspace tool.

Maxim Mikityanskiy (3):
  ethtool: Fix preserving of wanted feature bits in netlink interface
  ethtool: Account for hw_features in netlink interface
  ethtool: Don't omit the netlink reply if no features were changed

 net/ethtool/features.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Florian Fainelli Aug. 14, 2020, 2:58 p.m. UTC | #1 
On 8/14/2020 6:16 AM, Maxim Mikityanskiy wrote:
> This series contains a few bug fixes for ethtool-netlink. These bugs are
> specific for the netlink interface, and the legacy ioctl interface is
> not affected. These patches aim to have the same behavior in
> ethtool-netlink as in the legacy ethtool.
> 
> Please also see the sibling series for the userspace tool.

Since you are targeting the net tree, should not those changes also have 
corresponding Fixes tag?

Thanks

> 
> Maxim Mikityanskiy (3):
>    ethtool: Fix preserving of wanted feature bits in netlink interface
>    ethtool: Account for hw_features in netlink interface
>    ethtool: Don't omit the netlink reply if no features were changed
> 
>   net/ethtool/features.c | 19 ++++++++++---------
>   1 file changed, 10 insertions(+), 9 deletions(-)
>
David Miller Aug. 15, 2020, 3:45 a.m. UTC | #2 
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Fri, 14 Aug 2020 07:58:29 -0700

> 
> 
> On 8/14/2020 6:16 AM, Maxim Mikityanskiy wrote:
>> This series contains a few bug fixes for ethtool-netlink. These bugs
>> are
>> specific for the netlink interface, and the legacy ioctl interface is
>> not affected. These patches aim to have the same behavior in
>> ethtool-netlink as in the legacy ethtool.
>> Please also see the sibling series for the userspace tool.
> 
> Since you are targeting the net tree, should not those changes also
> have corresponding Fixes tag?

Yes, they definitely should.