From patchwork Tue Aug 4 10:18:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1340780 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BLW181JHCz9sTC for ; Tue, 4 Aug 2020 20:18:20 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728763AbgHDKSS (ORCPT ); Tue, 4 Aug 2020 06:18:18 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44459 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728734AbgHDKSP (ORCPT ); Tue, 4 Aug 2020 06:18:15 -0400 Received: from mail-pj1-f71.google.com ([209.85.216.71]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1k2u1N-0006ZW-BW for netdev@vger.kernel.org; Tue, 04 Aug 2020 10:18:13 +0000 Received: by mail-pj1-f71.google.com with SMTP id ck13so1874834pjb.6 for ; Tue, 04 Aug 2020 03:18:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=lztI+52PEieuECGw0yo1p950jYaSkaNvNIxQ6AqqJrE=; b=KKEfMnBgYhmVS7ioDRo0YHniH9S7nDl0naVEj2TaKBx2G/7irQEuIAVIBBYnctR2xm YlGYGrploB1QFWtnK2NjkeUoZFNsWRBnfB0qbPL3qzzFUlsW/PD1SOHjcEGm3ww27O/a lDnTDjHYQouh/XcW21SNKU8p3LYcNyKHcWV6v4nhzfhBwSk1K4H8UqwBfcUnqUT7kI/a qg7efUrdXTvTUTaUhRXzO1rI5tO2nR1bbmATsL0k6HIzqk4twoKDgEf2J+ilur5l3Aqa hvd6zUkw2zmFFe4wHPlY9lWBN15RminmRyNTP++74LUEYKZeh8WORdYxSbJPNX5zLbAR TjRQ== X-Gm-Message-State: AOAM532NCuOBBO20hsabEUkgWR7gy40fkX9jSkJM4R3871cU2GgFzy5Y QhtlCgNK75vdgkmeBSrXxvEVzptd+6U4JRy7q48/kMpI+DJ81kehJvAdRQnmB8SFHdtL8YyQkBF n9OgA/0GAM3jZQkXMGwjz1ZHii9MKDfE6 X-Received: by 2002:a63:fe0a:: with SMTP id p10mr18203115pgh.255.1596536292071; Tue, 04 Aug 2020 03:18:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzIHL8sYbPiRAjs0p3Qdwl8e3TgS6Y0hi0jCRXOqp6aBTdO0DvtzFLybPtMSrdBKmAqvym13g== X-Received: by 2002:a63:fe0a:: with SMTP id p10mr18203102pgh.255.1596536291745; Tue, 04 Aug 2020 03:18:11 -0700 (PDT) Received: from localhost.localdomain (111-71-32-223.emome-ip.hinet.net. [111.71.32.223]) by smtp.gmail.com with ESMTPSA id g15sm15578674pfh.70.2020.08.04.03.18.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 03:18:10 -0700 (PDT) From: Po-Hsu Lin To: davem@davemloft.net, kuba@kernel.org, skhan@linuxfoundation.org Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/2] selftests: rtnetlink: Fix for false-negative return values Date: Tue, 4 Aug 2020 18:18:01 +0800 Message-Id: <20200804101803.23062-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patchset will address the false-negative return value issue caused by the following: 1. The return value "ret" in this script will be reset to 0 from the beginning of each sub-test in rtnetlink.sh, therefore this rtnetlink test will always pass if the last sub-test has passed. 2. The test result from two sub-tests in kci_test_encap() were not being processed, thus they will not affect the final test result of this test. Po-Hsu Lin (2): selftests: rtnetlink: correct the final return value for the test selftests: rtnetlink: make kci_test_encap() return sub-test result tools/testing/selftests/net/rtnetlink.sh | 68 +++++++++++++++++++++----------- 1 file changed, 46 insertions(+), 22 deletions(-)