From patchwork Fri Jul 24 09:06:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Quentin Monnet X-Patchwork-Id: 1335527 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=isovalent.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=isovalent-com.20150623.gappssmtp.com header.i=@isovalent-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=Nxk5OLgH; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4BCjxc3Y2gz9sSt for ; Fri, 24 Jul 2020 19:06:44 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727846AbgGXJGn (ORCPT ); Fri, 24 Jul 2020 05:06:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53028 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727786AbgGXJGl (ORCPT ); Fri, 24 Jul 2020 05:06:41 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B577C0619E4 for ; Fri, 24 Jul 2020 02:06:40 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id y3so7608357wrl.4 for ; Fri, 24 Jul 2020 02:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YflWa3w8Y5oTGYdnHuXIQRIDPp5Y24q+DCQaGq5dkSE=; b=Nxk5OLgH64H9CUtnJ45wu53Lo/7RCf6rr9KOe+69FciFgJ58b63821VXdUe9oHmBL4 8xgOG3ajI2YzN7pAOQ+GqeXr6mSpeZxIxG7qZWqYVLbIBxS5r01LzVI+nW5fmAtpullx 6w3trNFMcLEoV63gJsjxR50Sm9+jqksW82cI5vX3fIFdV3WVW8X5SmlL1jVmaePhtXoj bTAGl+JkY2gTcUDY0vxzc539Wd/h4wF/C6IggnM0k9UeAmsYcM4nhGFxxZe0J3sHz7zv AT4wXGa1asoSyMuTsJh5bD4TOpnwyfVCPIX9GTB6SkUeJaWqNluIxv1L3rN76LDNBDXj uylA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YflWa3w8Y5oTGYdnHuXIQRIDPp5Y24q+DCQaGq5dkSE=; b=igNWo7AILbaM44TVYbt/ippp4CUjOy5BrDf/1vKxigQArpi+iU/4kCVHSgWlghr3E2 Nhfn5s1RWf6w/KwjGI9kBcScGA3R9e8OVa+5wDQFizxYt2femPmA7jzx2Wh7qabKN+Jx pZbYesVCQi545dMHZfoiEUIoXxAtDwcr5pWpZa4YcQQRkBzV5nPEEtVth5lzBhaCSDLV UgbXukzrsfWMLzFfMo7rbXVRK11UUPHaI3IEK4G8ehcKf+kZAwrC3oCapveQcZvzm10j Ar4npB+0OrRY1bekT6O+hk/7jKzwktSjgjJojJnuyFc0jvUIjDVQaxZ+3d6dIr07x/kP pdOQ== X-Gm-Message-State: AOAM531eDK42YnjGdwHG9A+7XSfj8EXDB8wOWkEqW/XoRxOSNcTWL6pP sbA7yMzaIVKO0FouufhPN+eHAQ== X-Google-Smtp-Source: ABdhPJwPKGwW+3QETZQ5Fsamse3ZXXCaPUYKm9kxsDR4+7dL+3LiJcgbhr31IfZ7Zv30HV7gKRMkfA== X-Received: by 2002:a5d:4fc2:: with SMTP id h2mr7265176wrw.333.1595581597792; Fri, 24 Jul 2020 02:06:37 -0700 (PDT) Received: from localhost.localdomain ([194.35.117.75]) by smtp.gmail.com with ESMTPSA id t11sm527915wrs.66.2020.07.24.02.06.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 02:06:37 -0700 (PDT) From: Quentin Monnet To: Alexei Starovoitov , Daniel Borkmann Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, Paul Chaignon , Quentin Monnet Subject: [PATCH bpf-next 0/2] tools: bpftool: update prog names list and fix segfault Date: Fri, 24 Jul 2020 10:06:16 +0100 Message-Id: <20200724090618.16378-1-quentin@isovalent.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Although probing features with bpftool works fine if bpftool's array of program and map type names lack the latest kernel additions, it can crash if there are some types missing _in the middle_ of the arrays. The case recently occurred with the addition of the "sk_lookup" name, which skipped the "lsm" in the list. Let's update the list, and let's make sure it does not crash bpftool again if we omit other types again in the future. Quentin Monnet (2): tools: bpftool: skip type probe if name is not found tools: bpftool: add LSM type to array of prog names tools/bpf/bpftool/feature.c | 8 ++++++++ tools/bpf/bpftool/prog.c | 1 + 2 files changed, 9 insertions(+)