mbox series

[net-next,v1,0/7] udp_tunnel: convert Intel drivers with shared tables

Message ID 20200722012716.2814777-1-kuba@kernel.org
Headers show
Series udp_tunnel: convert Intel drivers with shared tables | expand

Message

Jakub Kicinski July 22, 2020, 1:27 a.m. UTC 
This set converts Intel drivers which have the ability to spawn
multiple netdevs, but have only one UDP tunnel port table.

Appropriate support is added to the core infra in patch 1,
followed by netdevsim support and a selftest.

The table sharing works by core attaching the same table
structure to all devices sharing the table. This means the
reference count has to accommodate potentially large values.

Once core is ready i40e and ice are converted. These are
complex drivers, and I don't have HW to test so please
review..

Jakub Kicinski (7):
  udp_tunnel: add the ability to share port tables
  netdevsim: add warnings on unexpected UDP tunnel port errors
  netdevsim: shared UDP tunnel port table support
  selftests: net: add a test for shared UDP tunnel info tables
  i40e: convert to new udp_tunnel infrastructure
  ice: remove unused args from ice_get_open_tunnel_port()
  ice: convert to new udp_tunnel infrastructure

 drivers/net/ethernet/intel/i40e/i40e.h        |   6 +-
 drivers/net/ethernet/intel/i40e/i40e_main.c   | 264 ++++--------------
 .../net/ethernet/intel/ice/ice_ethtool_fdir.c |   6 +-
 drivers/net/ethernet/intel/ice/ice_fdir.c     |   2 +-
 .../net/ethernet/intel/ice/ice_flex_pipe.c    | 231 +++++++--------
 .../net/ethernet/intel/ice/ice_flex_pipe.h    |  11 +-
 .../net/ethernet/intel/ice/ice_flex_type.h    |   5 +-
 drivers/net/ethernet/intel/ice/ice_main.c     |  97 ++-----
 drivers/net/ethernet/intel/ice/ice_type.h     |   3 +
 drivers/net/netdevsim/netdevsim.h             |   7 +-
 drivers/net/netdevsim/udp_tunnels.c           |  30 +-
 include/net/udp_tunnel.h                      |  24 ++
 net/ipv4/udp_tunnel_nic.c                     |  96 ++++++-
 .../drivers/net/netdevsim/udp_tunnel_nic.sh   | 109 ++++++++
 14 files changed, 440 insertions(+), 451 deletions(-)

Comments

Tony Nguyen July 22, 2020, 9:22 p.m. UTC | #1 
On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
> This set converts Intel drivers which have the ability to spawn
> multiple netdevs, but have only one UDP tunnel port table.
> 
> Appropriate support is added to the core infra in patch 1,
> followed by netdevsim support and a selftest.
> 
> The table sharing works by core attaching the same table
> structure to all devices sharing the table. This means the
> reference count has to accommodate potentially large values.
> 
> Once core is ready i40e and ice are converted. These are
> complex drivers, and I don't have HW to test so please
> review..

I'm requesting our developers to take a look over and validation to
test the ice and i40e patches. I will report back when I get results.

Thanks,
Tony
Tony Nguyen July 23, 2020, 8:06 p.m. UTC | #2 
On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
> On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
> > This set converts Intel drivers which have the ability to spawn
> > multiple netdevs, but have only one UDP tunnel port table.
> > 
> > Appropriate support is added to the core infra in patch 1,
> > followed by netdevsim support and a selftest.
> > 
> > The table sharing works by core attaching the same table
> > structure to all devices sharing the table. This means the
> > reference count has to accommodate potentially large values.
> > 
> > Once core is ready i40e and ice are converted. These are
> > complex drivers, and I don't have HW to test so please
> > review..
> 
> I'm requesting our developers to take a look over and validation to
> test the ice and i40e patches. I will report back when I get results.

Would you mind if I pick these patches up into Jeff's tree? It will
make it easier to test that way.

Thanks,
Tony
David Miller July 23, 2020, 8:17 p.m. UTC | #3 
From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Date: Thu, 23 Jul 2020 20:06:15 +0000

> On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
>> On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:
>> > This set converts Intel drivers which have the ability to spawn
>> > multiple netdevs, but have only one UDP tunnel port table.
>> > 
>> > Appropriate support is added to the core infra in patch 1,
>> > followed by netdevsim support and a selftest.
>> > 
>> > The table sharing works by core attaching the same table
>> > structure to all devices sharing the table. This means the
>> > reference count has to accommodate potentially large values.
>> > 
>> > Once core is ready i40e and ice are converted. These are
>> > complex drivers, and I don't have HW to test so please
>> > review..
>> 
>> I'm requesting our developers to take a look over and validation to
>> test the ice and i40e patches. I will report back when I get results.
> 
> Would you mind if I pick these patches up into Jeff's tree? It will
> make it easier to test that way.

No objections on my end, and you can add my:

Acked-by: David S. Miller <davem@davemloft.net>
Jakub Kicinski Sept. 3, 2020, 11:22 p.m. UTC | #4 
On Thu, 23 Jul 2020 20:06:15 +0000 Nguyen, Anthony L wrote:
> On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
> > On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:  
> > > This set converts Intel drivers which have the ability to spawn
> > > multiple netdevs, but have only one UDP tunnel port table.
> > > 
> > > Appropriate support is added to the core infra in patch 1,
> > > followed by netdevsim support and a selftest.
> > > 
> > > The table sharing works by core attaching the same table
> > > structure to all devices sharing the table. This means the
> > > reference count has to accommodate potentially large values.
> > > 
> > > Once core is ready i40e and ice are converted. These are
> > > complex drivers, and I don't have HW to test so please
> > > review..  
> > 
> > I'm requesting our developers to take a look over and validation to
> > test the ice and i40e patches. I will report back when I get results.  
> 
> Would you mind if I pick these patches up into Jeff's tree? It will
> make it easier to test that way.

It's been a month. Any ETA on these?
Tony Nguyen Sept. 4, 2020, 4:12 p.m. UTC | #5 
On Thu, 2020-09-03 at 16:22 -0700, Jakub Kicinski wrote:
> On Thu, 23 Jul 2020 20:06:15 +0000 Nguyen, Anthony L wrote:
> > On Wed, 2020-07-22 at 14:22 -0700, Tony Nguyen wrote:
> > > On Tue, 2020-07-21 at 18:27 -0700, Jakub Kicinski wrote:  
> > > > This set converts Intel drivers which have the ability to spawn
> > > > multiple netdevs, but have only one UDP tunnel port table.
> > > > 
> > > > Appropriate support is added to the core infra in patch 1,
> > > > followed by netdevsim support and a selftest.
> > > > 
> > > > The table sharing works by core attaching the same table
> > > > structure to all devices sharing the table. This means the
> > > > reference count has to accommodate potentially large values.
> > > > 
> > > > Once core is ready i40e and ice are converted. These are
> > > > complex drivers, and I don't have HW to test so please
> > > > review..  
> > > 
> > > I'm requesting our developers to take a look over and validation
> > > to
> > > test the ice and i40e patches. I will report back when I get
> > > results.  
> > 
> > Would you mind if I pick these patches up into Jeff's tree? It will
> > make it easier to test that way.
> 
> It's been a month. Any ETA on these?

Sorry for taking so long. Let me check on the status and get back to
you.

Thanks,
Tony