mbox series

[net-next,0/4] devlink small improvements

Message ID 20200721165354.5244-1-parav@mellanox.com
Headers show
Series devlink small improvements | expand

Message

Parav Pandit July 21, 2020, 4:53 p.m. UTC 
Hi Jakub, Dave,

This short series improves the devlink code for lock commment,
simplifying checks and keeping the scope of mutex lock for necessary
fields.

Patch summary:
Patch-1 Keep the devlink_mutex for only for necessary changes.
Patch-2 Avoids duplicate check for reload flag
Patch-3 Adds missing comment for the scope of devlink instance lock
Patch-4 Constify devlink instance pointer


Parav Pandit (4):
  devlink: Do not hold devlink mutex when initializing devlink fields
  devlink: Avoid duplicate check for reload enabled flag
  devlink: Add comment for devlink instance lock
  devlink: Constify devlink instance pointer

 include/net/devlink.h | 4 +++-
 net/core/devlink.c    | 6 +++---
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Jakub Kicinski July 21, 2020, 7:32 p.m. UTC | #1 
On Tue, 21 Jul 2020 19:53:50 +0300 Parav Pandit wrote:
> Hi Jakub, Dave,
> 
> This short series improves the devlink code for lock commment,
> simplifying checks and keeping the scope of mutex lock for necessary
> fields.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>
David Miller July 21, 2020, 11:15 p.m. UTC | #2 
From: Parav Pandit <parav@mellanox.com>
Date: Tue, 21 Jul 2020 19:53:50 +0300

> This short series improves the devlink code for lock commment,
> simplifying checks and keeping the scope of mutex lock for necessary
> fields.
> 
> Patch summary:
> Patch-1 Keep the devlink_mutex for only for necessary changes.
> Patch-2 Avoids duplicate check for reload flag
> Patch-3 Adds missing comment for the scope of devlink instance lock
> Patch-4 Constify devlink instance pointer

Series applied, thank you.