mbox series

[v2,0/2] Interrupt handler support for NPA and NIX in Octeontx2.

Message ID 20200721023847.2567-1-rakeshs.lkm@gmail.com
Headers show
Series Interrupt handler support for NPA and NIX in Octeontx2. | expand

Message

rakeshs.lkm@gmail.com July 21, 2020, 2:38 a.m. UTC 
From: Rakesh Babu <rakeshs.lkm@gmail.com>

Changes from v1.
1. Assigned void pointers to another type of pointers without type casting.
2. Removed Switch and If cases in interrupt handlers and printed the hexa
value of the interrupt

Jerin Jacob (2):
  octeontx2-af: add npa error af interrupt handlers
  octeontx2-af: add nix error af interrupt handlers

 .../net/ethernet/marvell/octeontx2/af/rvu.c   |  12 ++
 .../net/ethernet/marvell/octeontx2/af/rvu.h   |   4 +
 .../ethernet/marvell/octeontx2/af/rvu_nix.c   | 148 +++++++++++++++
 .../ethernet/marvell/octeontx2/af/rvu_npa.c   | 176 ++++++++++++++++++
 .../marvell/octeontx2/af/rvu_struct.h         |  20 ++
 5 files changed, 360 insertions(+)

--
2.17.1

Comments

Jakub Kicinski July 21, 2020, 7:23 p.m. UTC | #1 
On Tue, 21 Jul 2020 08:08:45 +0530 rakeshs.lkm@gmail.com wrote:
> From: Rakesh Babu <rakeshs.lkm@gmail.com>
> 
> Changes from v1.
> 1. Assigned void pointers to another type of pointers without type casting.
> 2. Removed Switch and If cases in interrupt handlers and printed the hexa
> value of the interrupt

These days error events should be reported via devlink health, 
not printing messages to the logs.
David Miller July 21, 2020, 11:22 p.m. UTC | #2 
From: Jakub Kicinski <kuba@kernel.org>
Date: Tue, 21 Jul 2020 12:23:29 -0700

> On Tue, 21 Jul 2020 08:08:45 +0530 rakeshs.lkm@gmail.com wrote:
>> From: Rakesh Babu <rakeshs.lkm@gmail.com>
>> 
>> Changes from v1.
>> 1. Assigned void pointers to another type of pointers without type casting.
>> 2. Removed Switch and If cases in interrupt handlers and printed the hexa
>> value of the interrupt
> 
> These days error events should be reported via devlink health, 
> not printing messages to the logs.

+1