mbox series

[net-next,0/2] net: phy: Uninline PHY ethtool statistics

Message ID 20200708164625.40180-1-f.fainelli@gmail.com
Headers show
Series net: phy: Uninline PHY ethtool statistics | expand

Message

Florian Fainelli July 8, 2020, 4:46 p.m. UTC 
Hi all,

Now that we have introduced ethtool_phy_ops we can uninline those
operations and move them back into phy.c where they belong. Since those
functions are used by DSA, we need to continue exporting those symbols.

It might be possible to remove ndo_get_ethtool_phy_stats in a subsequent
patch since we could have DSA register its own ethtool_phy_ops instance
instead of overloading the ethtool_ops.

Florian Fainelli (2):
  net: phy: Define PHY statistics ethtool_phy_ops
  net: phy: Uninline PHY ethtool statistics operations

 drivers/net/phy/phy.c        | 48 +++++++++++++++++++++++++++++++++++
 drivers/net/phy/phy_device.c |  3 +++
 include/linux/ethtool.h      |  7 ++++++
 include/linux/phy.h          | 49 +++---------------------------------
 net/ethtool/ioctl.c          | 23 +++++++++++------
 net/ethtool/strset.c         | 11 +++++---
 6 files changed, 84 insertions(+), 57 deletions(-)

Comments

David Miller July 8, 2020, 7:39 p.m. UTC | #1 
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed,  8 Jul 2020 09:46:23 -0700

> Now that we have introduced ethtool_phy_ops we can uninline those
> operations and move them back into phy.c where they belong. Since those
> functions are used by DSA, we need to continue exporting those symbols.
> 
> It might be possible to remove ndo_get_ethtool_phy_stats in a subsequent
> patch since we could have DSA register its own ethtool_phy_ops instance
> instead of overloading the ethtool_ops.

Series applied, thanks Florian.