mbox series

[net-next,v2,0/3] net: ethtool: Untangle PHYLIB dependency

Message ID 20200706042758.168819-1-f.fainelli@gmail.com
Headers show
Series net: ethtool: Untangle PHYLIB dependency | expand

Message

Florian Fainelli July 6, 2020, 4:27 a.m. UTC 
Hi all,

This patch series untangles the ethtool netlink dependency with PHYLIB
which exists because the cable test feature calls directly into PHY
library functions. The approach taken here is to introduce
ethtool_phy_ops function pointers which can be dynamically registered
when PHYLIB loads.

Florian Fainelli (3):
  net: ethtool: Introduce ethtool_phy_ops
  net: phy: Register ethtool PHY operations
  net: ethtool: Remove PHYLIB direct dependency

 drivers/net/phy/phy_device.c |  7 +++++++
 include/linux/ethtool.h      | 25 +++++++++++++++++++++++++
 net/Kconfig                  |  1 -
 net/ethtool/cabletest.c      | 18 ++++++++++++++++--
 net/ethtool/common.c         | 11 +++++++++++
 net/ethtool/common.h         |  2 ++
 6 files changed, 61 insertions(+), 3 deletions(-)

Comments

Andrew Lunn July 6, 2020, 1:46 p.m. UTC | #1 
On Sun, Jul 05, 2020 at 09:27:55PM -0700, Florian Fainelli wrote:
> Hi all,
> 
> This patch series untangles the ethtool netlink dependency with PHYLIB
> which exists because the cable test feature calls directly into PHY
> library functions. The approach taken here is to introduce
> ethtool_phy_ops function pointers which can be dynamically registered
> when PHYLIB loads.
 
Hi Florian

This looks good. I would suggest leaving it a day or two for 0-day to
randconfig it for a while.

	   Andrew
David Miller July 7, 2020, 10:41 p.m. UTC | #2 
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Sun,  5 Jul 2020 21:27:55 -0700

> This patch series untangles the ethtool netlink dependency with PHYLIB
> which exists because the cable test feature calls directly into PHY
> library functions. The approach taken here is to introduce
> ethtool_phy_ops function pointers which can be dynamically registered
> when PHYLIB loads.

Series applied, thanks for doing this work Florian.