| Message ID | 20200701213433.9217-1-michael@walle.cc |
|---|---|
| Headers | show |
| Series | net: enetc: remove bootloader dependency | expand |
On Wed, Jul 01, 2020 at 11:34:30PM +0200, Michael Walle wrote: > This is a resend of the series because the conversion to the phylink > interface will likely take longer: > https://lore.kernel.org/netdev/CA+h21hpBodyY8CtNH2ktRdc2FqPi=Fjp94=VVZvzSVbnvnfKVg@mail.gmail.com/ I don't think it will; I've given people notice of potential changes back in February, and as Florian has pointed out, that's ample enough time that it's now no problem if I push my series and it causes breakage to drivers that haven't updated. I've also gone way beyond what would normally be done, fixing up almost every driver the best I can with the exception of two - felix DSA and Mediatek. Some of the patches have been reviewed already, Ioana at NXP is happy with them. There's a bit of tweaking of a couple of patches and adding some documentation, and then they're good to go. I'm not going to wait for Felix or Mediatek. As I say, I've given plenty of warning, and it's only a _suspicion_ of breakage on my side.
On Thu, 2 Jul 2020 at 00:53, Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > > fixing up almost every driver the best I can with the exception of two - > felix DSA and Mediatek. > > I'm not going to wait for Felix or Mediatek. As I say, I've given > plenty of warning, and it's only a _suspicion_ of breakage on my > side. > What do you mean "I'm not going to wait for Felix"? https://patchwork.ozlabs.org/project/netdev/patch/20200625152331.3784018-5-olteanv@gmail.com/ We left it at: > I'm not going to review patch 7 > tonight because of this fiasco. To pissed off to do a decent job, so > you're just going to have to wait. So, I was actively waiting for you to review it ever since, just like you said, so I could send a v2. Were you waiting for anything? Thank you, -Vladimir
On Thu, Jul 02, 2020 at 01:04:02AM +0300, Vladimir Oltean wrote: > On Thu, 2 Jul 2020 at 00:53, Russell King - ARM Linux admin > <linux@armlinux.org.uk> wrote: > > > > fixing up almost every driver the best I can with the exception of two - > > felix DSA and Mediatek. > > > > I'm not going to wait for Felix or Mediatek. As I say, I've given > > plenty of warning, and it's only a _suspicion_ of breakage on my > > side. > > > > What do you mean "I'm not going to wait for Felix"? > https://patchwork.ozlabs.org/project/netdev/patch/20200625152331.3784018-5-olteanv@gmail.com/ > We left it at: > > > I'm not going to review patch 7 > > tonight because of this fiasco. To pissed off to do a decent job, so > > you're just going to have to wait. > > So, I was actively waiting for you to review it ever since, just like > you said, so I could send a v2. Were you waiting for anything? I stopped being interested in your series with the patch 5 commit description issue; what happened there is really demotivating.
On Thu, 2 Jul 2020 at 11:41, Russell King - ARM Linux admin <linux@armlinux.org.uk> wrote: > > On Thu, Jul 02, 2020 at 01:04:02AM +0300, Vladimir Oltean wrote: > > On Thu, 2 Jul 2020 at 00:53, Russell King - ARM Linux admin > > <linux@armlinux.org.uk> wrote: > > > > > > fixing up almost every driver the best I can with the exception of two - > > > felix DSA and Mediatek. > > > > > > I'm not going to wait for Felix or Mediatek. As I say, I've given > > > plenty of warning, and it's only a _suspicion_ of breakage on my > > > side. > > > > > > > What do you mean "I'm not going to wait for Felix"? > > https://patchwork.ozlabs.org/project/netdev/patch/20200625152331.3784018-5-olteanv@gmail.com/ > > We left it at: > > > > > I'm not going to review patch 7 > > > tonight because of this fiasco. To pissed off to do a decent job, so > > > you're just going to have to wait. > > > > So, I was actively waiting for you to review it ever since, just like > > you said, so I could send a v2. Were you waiting for anything? > > I stopped being interested in your series with the patch 5 commit > description issue; what happened there is really demotivating. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! Yes, but I mean, the fact that reviewing felix is "demotivating" can only have 2 courses of action as far as I can see: - I do resubmit the series with feedback that you've given so far, but it's likely going to take a few more iterations because you haven't reviewed the current series in its entirety, and you haven't in fact reviewed the part which you consider as a dependency for your work yet (the mac_link_up conversion). But this goes against your argument that the lynx pcs will land quickly, so Michael should just wait a little bit more. - As per your "I'm not going to wait for Felix or Mediatek" phrase, you might decide you just don't deal with DSA any longer, and you proceed with the PCS patches by essentially breaking the dependency. In this case, I'm not sure why Michael would need to wait either, since _you_ are deciding to not wait for DSA, neither is he. I'm fine either way, but one thing is not going to change, and that's the ordering of my patches in the "PHYLINK integration improvements for Felix DSA driver" series. As you know, most NXP users are not using David's net-next directly (and that is at their! request), but a "vendor" kernel which we try to keep as close to David's tree as humanly possible, and which goes through a lot of testing. But if there are going to be treewide changes in the phylink API (and there _are_ already, that mac_link_up thing, which we haven't backported), then there needs to be a strict ordering relationship between the cleanup commits, which we can cherry-pick, and the adaptation to an API which we haven't (nor we intend to) backport to 5.4, because it's too much for little practical benefit. You seem to be hung up on that, and we won't be making much progress if that continues, I'm afraid. There are a lot of things to be done that depend on the lynx-pcs thing, and there are multiple groups of people who are all waiting. The new seville DSA driver, which _almost_ got into the previous release cycle but missed the train due to a dependency with Mark Brown's tree, also has a Lynx PCS integrated in it. I would like to reuse the lynx-pcs module, but from what I can see, the bottleneck for everybody seems to be reviewing the mac_link_up conversion of felix. Thank you, -Vladimir
On Thu, Jul 02, 2020 at 12:41:39PM +0300, Vladimir Oltean wrote: > On Thu, 2 Jul 2020 at 11:41, Russell King - ARM Linux admin > <linux@armlinux.org.uk> wrote: > > > > On Thu, Jul 02, 2020 at 01:04:02AM +0300, Vladimir Oltean wrote: > > > On Thu, 2 Jul 2020 at 00:53, Russell King - ARM Linux admin > > > <linux@armlinux.org.uk> wrote: > > > > > > > > fixing up almost every driver the best I can with the exception of two - > > > > felix DSA and Mediatek. > > > > > > > > I'm not going to wait for Felix or Mediatek. As I say, I've given > > > > plenty of warning, and it's only a _suspicion_ of breakage on my > > > > side. > > > > > > > > > > What do you mean "I'm not going to wait for Felix"? > > > https://patchwork.ozlabs.org/project/netdev/patch/20200625152331.3784018-5-olteanv@gmail.com/ > > > We left it at: > > > > > > > I'm not going to review patch 7 > > > > tonight because of this fiasco. To pissed off to do a decent job, so > > > > you're just going to have to wait. > > > > > > So, I was actively waiting for you to review it ever since, just like > > > you said, so I could send a v2. Were you waiting for anything? > > > > I stopped being interested in your series with the patch 5 commit > > description issue; what happened there is really demotivating. > > > > -- > > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > > FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! > > Yes, but I mean, the fact that reviewing felix is "demotivating" can > only have 2 courses of action as far as I can see: Sigh. I give up with you.