mbox series

[net-next,0/4] tcp: improve delivered counts in SCM_TSTAMP_ACK

Message ID 20200627040535.858564-1-ysseung@google.com
Headers show
Series tcp: improve delivered counts in SCM_TSTAMP_ACK | expand

Message

Yousuk Seung June 27, 2020, 4:05 a.m. UTC 
Currently delivered and delivered_ce in OPT_STATS of SCM_TSTAMP_ACK do
not fully reflect the current ack being timestamped. Also they are not
in sync as the delivered count includes packets being sacked and some of
cumulatively acked but delivered_ce includes none.

This patch series updates tp->delivered and tp->delivered_ce together to
keep them in sync. It also moves generating SCM_TSTAMP_ACK to later in
tcp_clean_rtx_queue() to reflect packets being cumulatively acked up
until the current skb for sack-enabled connections.

Yousuk Seung (4):
  tcp: stamp SCM_TSTAMP_ACK later in tcp_clean_rtx_queue()
  tcp: add ece_ack flag to reno sack functions
  tcp: count sacked packets in tcp_sacktag_state
  tcp: update delivered_ce with delivered

 net/ipv4/tcp_input.c | 59 +++++++++++++++++++++++++++++---------------
 1 file changed, 39 insertions(+), 20 deletions(-)

Comments

David Miller June 28, 2020, 12:41 a.m. UTC | #1 
From: Yousuk Seung <ysseung@google.com>
Date: Fri, 26 Jun 2020 21:05:31 -0700

> Currently delivered and delivered_ce in OPT_STATS of SCM_TSTAMP_ACK do
> not fully reflect the current ack being timestamped. Also they are not
> in sync as the delivered count includes packets being sacked and some of
> cumulatively acked but delivered_ce includes none.
> 
> This patch series updates tp->delivered and tp->delivered_ce together to
> keep them in sync. It also moves generating SCM_TSTAMP_ACK to later in
> tcp_clean_rtx_queue() to reflect packets being cumulatively acked up
> until the current skb for sack-enabled connections.

Series applied, thank you.