From patchwork Sun Jun 21 11:00:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ioana Ciornei X-Patchwork-Id: 1313886 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=nxp.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 49qV203XRDz9sQt for ; Sun, 21 Jun 2020 21:00:24 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729909AbgFULAU (ORCPT ); Sun, 21 Jun 2020 07:00:20 -0400 Received: from inva020.nxp.com ([92.121.34.13]:48260 "EHLO inva020.nxp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729732AbgFULAS (ORCPT ); Sun, 21 Jun 2020 07:00:18 -0400 Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 2D3831A16DA; Sun, 21 Jun 2020 13:00:15 +0200 (CEST) Received: from inva024.eu-rdc02.nxp.com (inva024.eu-rdc02.nxp.com [134.27.226.22]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 204651A06B8; Sun, 21 Jun 2020 13:00:15 +0200 (CEST) Received: from fsr-ub1864-126.ea.freescale.net (fsr-ub1864-126.ea.freescale.net [10.171.82.212]) by inva024.eu-rdc02.nxp.com (Postfix) with ESMTP id A5304203C2; Sun, 21 Jun 2020 13:00:14 +0200 (CEST) From: Ioana Ciornei To: netdev@vger.kernel.org, davem@davemloft.net Cc: vladimir.oltean@nxp.com, claudiu.manoil@nxp.com, alexandru.marginean@nxp.com, michael@walle.cc, andrew@lunn.ch, linux@armlinux.org.uk, f.fainelli@gmail.com, olteanv@gmail.com, Ioana Ciornei Subject: [PATCH net-next v2 0/5] net: phy: add Lynx PCS MDIO module Date: Sun, 21 Jun 2020 14:00:00 +0300 Message-Id: <20200621110005.23306-1-ioana.ciornei@nxp.com> X-Mailer: git-send-email 2.17.1 X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add support for the Lynx PCS as a separate module in drivers/net/phy/. The advantage of this structure is that multiple ethernet or switch drivers used on NXP hardware (ENETC, Felix DSA switch etc) can share the same implementation of PCS configuration and runtime management. The PCS is represented as an mdio_device and the callbacks exported are highly tied with PHYLINK and can't be used without it. The first 3 patches add some missing pieces in PHYLINK and the locked mdiobus write accessor. Next, the Lynx PCS MDIO module is added as a standalone module. The majority of the code is extracted from the Felix DSA driver. The last patch makes the necessary changes in the Felix driver in order to use the new common PCS implementation. At the moment, USXGMII (only with in-band AN and speeds up to 2500), SGMII, QSGMII (with and without in-band AN) and 2500Base-X (only w/o in-band AN) are supported by the Lynx PCS MDIO module since these were also supported by Felix and no functional change is intended at this time. Changes in v2: * got rid of the mdio_lynx_pcs structure and directly exported the functions without the need of an indirection * made the necessary adjustments for this in the Felix DSA driver * solved the broken allmodconfig build test by making the module tristate instead of bool * fixed a memory leakage in the Felix driver (the pcs structure was allocated twice) At this moment in time, I do not feel like a major restructuring is needed (ie export directly a phylink_pcs_ops from the Lynx module). I feel like this would limit consumers (MAC drivers) to use all or nothing, with no option of doing any MDIO reads/writes of their own (not part of the common code). Also, there is already a precedent of a PCS module (mdio-xpcs.c, the model of which I have followed) and without also changing that (which I am not comfortable doing) there is no point of changing this one. Ioana Ciornei (4): net: phylink: consider QSGMII interface mode in phylink_mii_c22_pcs_get_state net: mdiobus: add clause 45 mdiobus write accessor net: phy: add Lynx PCS MDIO module net: dsa: felix: use the Lynx PCS helpers Russell King (1): net: phylink: add interface to configure clause 22 PCS PHY MAINTAINERS | 7 + drivers/net/dsa/ocelot/Kconfig | 1 + drivers/net/dsa/ocelot/felix.c | 5 + drivers/net/dsa/ocelot/felix.h | 7 +- drivers/net/dsa/ocelot/felix_vsc9959.c | 371 ++----------------------- drivers/net/phy/Kconfig | 6 + drivers/net/phy/Makefile | 1 + drivers/net/phy/mdio-lynx-pcs.c | 337 ++++++++++++++++++++++ drivers/net/phy/phylink.c | 38 +++ include/linux/fsl/enetc_mdio.h | 21 -- include/linux/mdio-lynx-pcs.h | 25 ++ include/linux/mdio.h | 6 + include/linux/phylink.h | 3 + 13 files changed, 461 insertions(+), 367 deletions(-) create mode 100644 drivers/net/phy/mdio-lynx-pcs.c create mode 100644 include/linux/mdio-lynx-pcs.h