mbox series

[bpf,0/2] Two fixes for make kselftest TARGETS=bpf

Message ID 20200602175649.2501580-1-iii@linux.ibm.com
Headers show
Series Two fixes for make kselftest TARGETS=bpf | expand

Message

Ilya Leoshkevich June 2, 2020, 5:56 p.m. UTC 
While the primary documented way to run BPF tests is by invoking
make in tools/testing/selftests/bpf, kselftest documentation implies that
make kselftest TARGETS=bpf from the top directory should work as well.
This patch series contains two fixes that were neccesary to make it run:

- Patch 1: $(COMPILE.c) -> $(CC) $(CFLAGS) -c
- Patch 2: Add CXX=$(CROSS_COMPILE)g++ default value

Ilya Leoshkevich (2):
  tools/bpf: Don't use $(COMPILE.c)
  selftests/bpf: Add a default $(CXX) value

 tools/bpf/Makefile                   | 6 +++---
 tools/bpf/bpftool/Makefile           | 8 ++++----
 tools/testing/selftests/bpf/Makefile | 1 +
 3 files changed, 8 insertions(+), 7 deletions(-)

Comments

Daniel Borkmann June 2, 2020, 8:37 p.m. UTC | #1 
On 6/2/20 7:56 PM, Ilya Leoshkevich wrote:
> While the primary documented way to run BPF tests is by invoking
> make in tools/testing/selftests/bpf, kselftest documentation implies that
> make kselftest TARGETS=bpf from the top directory should work as well.
> This patch series contains two fixes that were neccesary to make it run:
> 
> - Patch 1: $(COMPILE.c) -> $(CC) $(CFLAGS) -c
> - Patch 2: Add CXX=$(CROSS_COMPILE)g++ default value
> 
> Ilya Leoshkevich (2):
>    tools/bpf: Don't use $(COMPILE.c)
>    selftests/bpf: Add a default $(CXX) value
> 
>   tools/bpf/Makefile                   | 6 +++---
>   tools/bpf/bpftool/Makefile           | 8 ++++----
>   tools/testing/selftests/bpf/Makefile | 1 +
>   3 files changed, 8 insertions(+), 7 deletions(-)

I've tested on x86-64 and arm64 as well, applied, thanks!