mbox series

[rdma-next,v3,0/8] Driver part of the ECE

Message ID 20200526115440.205922-1-leon@kernel.org
Headers show
Series Driver part of the ECE | expand

Message

Leon Romanovsky May 26, 2020, 11:54 a.m. UTC 
From: Leon Romanovsky <leonro@mellanox.com>

Changelog:
v3:
 * Squashed patch "RDMA/mlx5: Advertise ECE support" into
 "RDMA/mlx5: Set ECE options during modify QP".
v2:
https://lore.kernel.org/linux-rdma/20200525174401.71152-1-leon@kernel.org
 * Rebased on latest wip/jgg-rdma-next branch, commit a94dae867c56
 * Fixed wrong setting of pm_state field in mlx5 conversion patch
 * Removed DC support for now
v1:
https://lore.kernel.org/linux-rdma/20200523132243.817936-1-leon@kernel.org
 * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This
   is handled in extra patch.
 * Improved comments and commit messages after feedback from Yishai.
 * Added Mark Z. ROB tags
v0:
https://lore.kernel.org/linux-rdma/20200520082919.440939-1-leon@kernel.org

----------------------------------------------------------------------

Hi,

This is driver part of the RDMA-CM ECE series [1].
According to the IBTA, ECE data is completely vendor specific, so this
series extends mlx5_ib create_qp and modify_qp structs with extra field
to pass ECE options to/from the application.

Thanks

[1]
https://lore.kernel.org/linux-rdma/20200413141538.935574-1-leon@kernel.org

Leon Romanovsky (8):
  net/mlx5: Add ability to read and write ECE options
  RDMA/mlx5: Get ECE options from FW during create QP
  RDMA/mlx5: Set ECE options during QP create
  RDMA/mlx5: Use direct modify QP implementation
  RDMA/mlx5: Remove manually crafted QP context the query call
  RDMA/mlx5: Convert modify QP to use MLX5_SET macros
  RDMA/mlx5: Set ECE options during modify QP
  RDMA/mlx5: Return ECE data after modify QP

 drivers/infiniband/hw/mlx5/main.c |   3 +
 drivers/infiniband/hw/mlx5/qp.c   | 478 +++++++++++++++++-------------
 drivers/infiniband/hw/mlx5/qp.h   |   6 +-
 drivers/infiniband/hw/mlx5/qpc.c  |  44 ++-
 include/linux/mlx5/mlx5_ifc.h     |  24 +-
 include/linux/mlx5/qp.h           |  66 -----
 include/uapi/rdma/mlx5-abi.h      |   9 +-
 7 files changed, 333 insertions(+), 297 deletions(-)

--
2.26.2

Comments

Jason Gunthorpe May 26, 2020, 7:04 p.m. UTC | #1 
On Tue, May 26, 2020 at 02:54:32PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Changelog:
> v3:
>  * Squashed patch "RDMA/mlx5: Advertise ECE support" into
>  "RDMA/mlx5: Set ECE options during modify QP".
> v2:
> https://lore.kernel.org/linux-rdma/20200525174401.71152-1-leon@kernel.org
>  * Rebased on latest wip/jgg-rdma-next branch, commit a94dae867c56
>  * Fixed wrong setting of pm_state field in mlx5 conversion patch
>  * Removed DC support for now
> v1:
> https://lore.kernel.org/linux-rdma/20200523132243.817936-1-leon@kernel.org
>  * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This
>    is handled in extra patch.
>  * Improved comments and commit messages after feedback from Yishai.
>  * Added Mark Z. ROB tags
> v0:
> https://lore.kernel.org/linux-rdma/20200520082919.440939-1-leon@kernel.org
> 
> 
> Hi,
> 
> This is driver part of the RDMA-CM ECE series [1].
> According to the IBTA, ECE data is completely vendor specific, so this
> series extends mlx5_ib create_qp and modify_qp structs with extra field
> to pass ECE options to/from the application.
> 
> Thanks
> 
> [1]
> https://lore.kernel.org/linux-rdma/20200413141538.935574-1-leon@kernel.org
> 
> Leon Romanovsky (8):
>   net/mlx5: Add ability to read and write ECE options
>   RDMA/mlx5: Get ECE options from FW during create QP
>   RDMA/mlx5: Set ECE options during QP create
>   RDMA/mlx5: Use direct modify QP implementation
>   RDMA/mlx5: Remove manually crafted QP context the query call
>   RDMA/mlx5: Convert modify QP to use MLX5_SET macros
>   RDMA/mlx5: Set ECE options during modify QP
>   RDMA/mlx5: Return ECE data after modify QP

It seems fine, can you add the one patch to the shared branch please

Thanks,
Jason
Leon Romanovsky May 27, 2020, 2:54 a.m. UTC | #2 
On Tue, May 26, 2020 at 04:04:20PM -0300, Jason Gunthorpe wrote:
> On Tue, May 26, 2020 at 02:54:32PM +0300, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Changelog:
> > v3:
> >  * Squashed patch "RDMA/mlx5: Advertise ECE support" into
> >  "RDMA/mlx5: Set ECE options during modify QP".
> > v2:
> > https://lore.kernel.org/linux-rdma/20200525174401.71152-1-leon@kernel.org
> >  * Rebased on latest wip/jgg-rdma-next branch, commit a94dae867c56
> >  * Fixed wrong setting of pm_state field in mlx5 conversion patch
> >  * Removed DC support for now
> > v1:
> > https://lore.kernel.org/linux-rdma/20200523132243.817936-1-leon@kernel.org
> >  * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This
> >    is handled in extra patch.
> >  * Improved comments and commit messages after feedback from Yishai.
> >  * Added Mark Z. ROB tags
> > v0:
> > https://lore.kernel.org/linux-rdma/20200520082919.440939-1-leon@kernel.org
> >
> >
> > Hi,
> >
> > This is driver part of the RDMA-CM ECE series [1].
> > According to the IBTA, ECE data is completely vendor specific, so this
> > series extends mlx5_ib create_qp and modify_qp structs with extra field
> > to pass ECE options to/from the application.
> >
> > Thanks
> >
> > [1]
> > https://lore.kernel.org/linux-rdma/20200413141538.935574-1-leon@kernel.org
> >
> > Leon Romanovsky (8):
> >   net/mlx5: Add ability to read and write ECE options
> >   RDMA/mlx5: Get ECE options from FW during create QP
> >   RDMA/mlx5: Set ECE options during QP create
> >   RDMA/mlx5: Use direct modify QP implementation
> >   RDMA/mlx5: Remove manually crafted QP context the query call
> >   RDMA/mlx5: Convert modify QP to use MLX5_SET macros
> >   RDMA/mlx5: Set ECE options during modify QP
> >   RDMA/mlx5: Return ECE data after modify QP
>
> It seems fine, can you add the one patch to the shared branch please

First patch is applied to the mlx5-next.

f55ece0e11c1 net/mlx5: Add ability to read and write ECE options

Thanks

>
> Thanks,
> Jason
Jason Gunthorpe May 27, 2020, 7:14 p.m. UTC | #3 
On Tue, May 26, 2020 at 02:54:32PM +0300, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@mellanox.com>
> 
> Changelog:
> v3:
>  * Squashed patch "RDMA/mlx5: Advertise ECE support" into
>  "RDMA/mlx5: Set ECE options during modify QP".
> v2:
> https://lore.kernel.org/linux-rdma/20200525174401.71152-1-leon@kernel.org
>  * Rebased on latest wip/jgg-rdma-next branch, commit a94dae867c56
>  * Fixed wrong setting of pm_state field in mlx5 conversion patch
>  * Removed DC support for now
> v1:
> https://lore.kernel.org/linux-rdma/20200523132243.817936-1-leon@kernel.org
>  * Fixed compatibility issue of "old" kernel vs. "new" rdma-core. This
>    is handled in extra patch.
>  * Improved comments and commit messages after feedback from Yishai.
>  * Added Mark Z. ROB tags
> v0:
> https://lore.kernel.org/linux-rdma/20200520082919.440939-1-leon@kernel.org
> 
> ----------------------------------------------------------------------
> 
> Hi,
> 
> This is driver part of the RDMA-CM ECE series [1].
> According to the IBTA, ECE data is completely vendor specific, so this
> series extends mlx5_ib create_qp and modify_qp structs with extra field
> to pass ECE options to/from the application.
> 
> Thanks
> 
> [1]
> https://lore.kernel.org/linux-rdma/20200413141538.935574-1-leon@kernel.org
> 
> Leon Romanovsky (8):
>   net/mlx5: Add ability to read and write ECE options
>   RDMA/mlx5: Get ECE options from FW during create QP
>   RDMA/mlx5: Set ECE options during QP create
>   RDMA/mlx5: Use direct modify QP implementation
>   RDMA/mlx5: Remove manually crafted QP context the query call
>   RDMA/mlx5: Convert modify QP to use MLX5_SET macros
>   RDMA/mlx5: Set ECE options during modify QP
>   RDMA/mlx5: Return ECE data after modify QP

Applied to for-next, thanks

Jason