| Message ID | 20200522120700.838-1-brgl@bgdev.pl |
|---|---|
| Headers | show |
| Series | mediatek: add support for MediaTek Ethernet MAC | expand |
From: Bartosz Golaszewski <brgl@bgdev.pl> Date: Fri, 22 May 2020 14:06:49 +0200 > This series adds support for the STAR Ethernet Controller present on MediaTeK > SoCs from the MT8* family. Series applied to net-next, thank you.
On 22/05/2020 23:20, David Miller wrote: > From: Bartosz Golaszewski <brgl@bgdev.pl> > Date: Fri, 22 May 2020 14:06:49 +0200 > >> This series adds support for the STAR Ethernet Controller present on MediaTeK >> SoCs from the MT8* family. > > Series applied to net-next, thank you. > If you say "series applied" do you mean you also applied the device tree parts? These should go through my branch, because there could be conflicts if there are other device tree patches from other series, not related with network, touching the same files. Regards, Matthias
From: Matthias Brugger <matthias.bgg@gmail.com> Date: Fri, 22 May 2020 23:31:50 +0200 > > > On 22/05/2020 23:20, David Miller wrote: >> From: Bartosz Golaszewski <brgl@bgdev.pl> >> Date: Fri, 22 May 2020 14:06:49 +0200 >> >>> This series adds support for the STAR Ethernet Controller present on MediaTeK >>> SoCs from the MT8* family. >> >> Series applied to net-next, thank you. >> > > If you say "series applied" do you mean you also applied the device tree parts? > These should go through my branch, because there could be conflicts if there are > other device tree patches from other series, not related with network, touching > the same files. It's starting to get rediculous and tedious to manage the DT changes when they are tied to new networking drivers and such. And in any event, it is the patch series submitter's responsibility to sort these issues out, separate the patches based upon target tree, and clearly indicate this in the introductory posting and Subject lines.
On 5/22/20 11:36 PM, David Miller wrote: > From: Matthias Brugger <matthias.bgg@gmail.com> > Date: Fri, 22 May 2020 23:31:50 +0200 > >> >> >> On 22/05/2020 23:20, David Miller wrote: >>> From: Bartosz Golaszewski <brgl@bgdev.pl> >>> Date: Fri, 22 May 2020 14:06:49 +0200 >>> >>>> This series adds support for the STAR Ethernet Controller present on MediaTeK >>>> SoCs from the MT8* family. >>> >>> Series applied to net-next, thank you. >>> >> >> If you say "series applied" do you mean you also applied the device tree parts? >> These should go through my branch, because there could be conflicts if there are >> other device tree patches from other series, not related with network, touching >> the same files. > > It's starting to get rediculous and tedious to manage the DT changes > when they are tied to new networking drivers and such. > > And in any event, it is the patch series submitter's responsibility to > sort these issues out, separate the patches based upon target tree, and > clearly indicate this in the introductory posting and Subject lines. > My experience in with other subsystems is that the DTS changes which enables de device are part of the series. They are normally prefixed with "arm64: dts:" or "ARM: dts:" for 32 bit SoCs. That also normally the way I detect patches which should through my tree. Anyway I'll try to remember submitters in the future to send DTS patches for network devices as separate series. That makes my life a bit more complicated as I afterwards have to find the related DTS series to the driver you accepted, but I'll try. Regards, Matthias
From: Bartosz Golaszewski <bgolaszewski@baylibre.com> This series adds support for the STAR Ethernet Controller present on MediaTeK SoCs from the MT8* family. First we convert the existing DT bindings for the PERICFG controller to YAML and add a new compatible string for mt8516 variant of it. Then we add the DT bindings for the MAC. Next we do some cleanup of the mediatek ethernet drivers directory. The largest patch in the series adds the actual new driver. The rest of the patches add DT fixups for the boards already supported upstream. v1 -> v2: - add a generic helper for retrieving the net_device associated with given private data - fix several typos in commit messages - remove MTK_MAC_VERSION and don't set the driver version - use NET_IP_ALIGN instead of a magic number (2) but redefine it as it defaults to 0 on arm64 - don't manually turn the carrier off in mtk_mac_enable() - process TX cleanup in napi poll callback - configure pause in the adjust_link callback - use regmap_read_poll_timeout() instead of handcoding the polling - use devres_find() to verify that struct net_device is managed by devres in devm_register_netdev() - add a patch moving all networking devres helpers into net/devres.c - tweak the dma barriers: remove where unnecessary and add comments to the remaining barriers - don't reset internal counters when enabling the NIC - set the net_device's mtu size instead of checking the framesize in ndo_start_xmit() callback - fix a race condition in waking up the netif queue - don't emit log messages on OOM errors - use dma_set_mask_and_coherent() - use eth_hw_addr_random() - rework the receive callback so that we reuse the previous skb if unmapping fails, like we already do if skb allocation fails - rework hash table operations: add proper timeout handling and clear bits when appropriate v2 -> v3: - drop the patch adding priv_to_netdev() and store the netdev pointer in the driver private data - add an additional dma_wmb() after reseting the descriptor in mtk_mac_ring_pop_tail() - check the return value of dma_set_mask_and_coherent() - improve the DT bindings for mtk-eth-mac: make the reg property in the example use single-cell address and size, extend the description of the PERICFG phandle and document the mdio sub-node - add a patch converting the old .txt bindings for PERICFG to yaml - limit reading the DMA memory by storing the mapped addresses in the driver private structure - add a patch documenting the existing networking devres helpers v3 -> v4: - drop the devres patches: they will be sent separately - call netdev_sent_queue() & netdev_completed_queue() where appropriate - don't redefine NET_IP_ALIGN: define a private constant in the driver - fix a couple typos - only disabe/enable the MAC in suspend/resume if netif is running - drop the count field from the ring structure and instead calculate the number of used descriptors from the tail and head indicies - rework the locking used to protect the ring structures from concurrent access: use cheaper spin_lock_bh() and completely disable the internal spinlock used by regmap - rework the interrupt handling to make it more fine-grained: onle re-enable TX and RX interrupts while they're needed, process the stats updates in a workqueue, not in napi context - shrink the code responsible for unmapping and freeing skb memory - rework the barriers as advised by Arnd v4 -> v5: - rename the driver to make it less confusing with the existing mtk_eth_soc ethernet driver - unregister the mdiobus at device's detachment - open-code spin lock calls to avoid calling the _bh variants where unnecessary - limit read-modify-write operations where possible when accessing descriptor memory - use READ_ONCE/WRITE_ONCE when modifying the status and data_ptr descriptor fields Bartosz Golaszewski (11): dt-bindings: convert the binding document for mediatek PERICFG to yaml dt-bindings: add new compatible to mediatek,pericfg dt-bindings: net: add a binding document for MediaTek STAR Ethernet MAC net: ethernet: mediatek: rename Kconfig prompt net: ethernet: mediatek: remove unnecessary spaces from Makefile net: ethernet: mtk-star-emac: new driver ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi ARM64: dts: mediatek: add the ethernet node to mt8516.dtsi ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards ARM64: dts: mediatek: add ethernet pins for pumpkin boards ARM64: dts: mediatek: enable ethernet on pumpkin boards .../arm/mediatek/mediatek,pericfg.txt | 36 - .../arm/mediatek/mediatek,pericfg.yaml | 64 + .../bindings/net/mediatek,eth-mac.yaml | 89 + arch/arm64/boot/dts/mediatek/mt8516.dtsi | 17 + .../boot/dts/mediatek/pumpkin-common.dtsi | 34 + drivers/net/ethernet/mediatek/Kconfig | 9 +- drivers/net/ethernet/mediatek/Makefile | 3 +- drivers/net/ethernet/mediatek/mtk_star_emac.c | 1678 +++++++++++++++++ 8 files changed, 1892 insertions(+), 38 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.txt create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml create mode 100644 Documentation/devicetree/bindings/net/mediatek,eth-mac.yaml create mode 100644 drivers/net/ethernet/mediatek/mtk_star_emac.c