mbox series

[net,0/5] wireguard fixes for 5.7-rc5

Message ID 20200506213306.1344212-1-Jason@zx2c4.com
Headers show
Series wireguard fixes for 5.7-rc5 | expand

Message

Jason A. Donenfeld May 6, 2020, 9:33 p.m. UTC
Hi Dave,

With Ubuntu and Debian having backported this into their kernels, we're
finally seeing testing from places we hadn't seen prior, which is nice.
With that comes more fixes:

1) The CI for PPC64 was running with extremely small stacks for 64-bit,
   causing spurious crashes in surprising places.

2) There's was an old leftover routing loop restriction, which no longer
   makes sense given the queueing architecture, and was causing problems
   for people who really did want nested routing.

3) Not yielding our kthread on CONFIG_PREEMPT_VOLUNTARY systems caused
   RCU stalls and other issues, reported by Wang Jian, with the fix
   suggested by Sultan Alsawaf.

4) Clang spewed warnings in a selftest for CONFIG_IPV6=n, reported by
   Arnd Bergmann.

5) A complicated if statement was simplified to an assignment while also
   making the likely/unlikely hinting more correct and simple, and
   increasing readability, suggested by Sultan.

Patches (2) and (3) have Fixes: lines and are probably good candidates
for stable.

Thanks,
Jason

Jason A. Donenfeld (5):
  wireguard: selftests: use normal kernel stack size on ppc64
  wireguard: socket: remove errant restriction on looping to self
  wireguard: send/receive: cond_resched() when processing worker
    ringbuffers
  wireguard: selftests: initalize ipv6 members to NULL to squelch clang
    warning
  wireguard: send/receive: use explicit unlikely branch instead of
    implicit coalescing

 drivers/net/wireguard/receive.c               | 15 +++---
 drivers/net/wireguard/selftest/ratelimiter.c  |  4 +-
 drivers/net/wireguard/send.c                  | 19 +++----
 drivers/net/wireguard/socket.c                | 12 -----
 tools/testing/selftests/wireguard/netns.sh    | 54 +++++++++++++++++--
 .../wireguard/qemu/arch/powerpc64le.config    |  1 +
 6 files changed, 72 insertions(+), 33 deletions(-)

Comments

David Miller May 7, 2020, 3:04 a.m. UTC | #1
From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Wed,  6 May 2020 15:33:01 -0600

> With Ubuntu and Debian having backported this into their kernels, we're
> finally seeing testing from places we hadn't seen prior, which is nice.
> With that comes more fixes:
 ...

Series applied.

> Patches (2) and (3) have Fixes: lines and are probably good candidates
> for stable.

Queued up for -stable.

Thanks.