From patchwork Thu Apr 16 16:20:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 1271787 Return-Path: X-Original-To: incoming-bpf@patchwork.ozlabs.org Delivered-To: patchwork-incoming-bpf@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org (client-ip=23.128.96.18; helo=vger.kernel.org; envelope-from=bpf-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20161025 header.b=MPGXXzBg; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by ozlabs.org (Postfix) with ESMTP id 4934GW4vdBz9sSc for ; Fri, 17 Apr 2020 02:21:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731795AbgDPQVG (ORCPT ); Thu, 16 Apr 2020 12:21:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726362AbgDPQVD (ORCPT ); Thu, 16 Apr 2020 12:21:03 -0400 Received: from mail-pl1-x649.google.com (mail-pl1-x649.google.com [IPv6:2607:f8b0:4864:20::649]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DAA3C061A0C for ; Thu, 16 Apr 2020 09:21:03 -0700 (PDT) Received: by mail-pl1-x649.google.com with SMTP id p1so3194032plq.6 for ; Thu, 16 Apr 2020 09:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=QaScWPrvN+bBa0cuWNJArKq6KBmuiJpXWRJFnVKPzZk=; b=MPGXXzBgL8V0UK0Wjmuk8tyxL0j5v5jsaHumAkRtFrCRYtLogPsyd1roR1b0RkIPD5 KUVcg0GD7GcaWyeAv6oD24p754NvAT8xqdgCYhuW9CnUncphKfBLVF++4BCTy9oIR+Sd nhDFVy7LR/tPURbvoLjx0hITNoHIxgxH8ZPgqDIfhBeR9+VuHQ1Dg/ApiqNfCRGg5s9P EPEGxKCliNioxSxQeFQWSNs4F33p8DCHnw7VSr4QvTIYP67vcmCakS0rzvCcPtrrG1Xc 8StG+9Q4jyr3HPH5TgFUczAZqgAGD+aZxPcjsafYp/8Cq5lfLRoruMTij+8sxcFCQ0C7 dkMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=QaScWPrvN+bBa0cuWNJArKq6KBmuiJpXWRJFnVKPzZk=; b=riYqWshVCFZukP3h8nx4BprblvQvnYnOp6UqPsdmD10PO1DzHr4X6X8X73P0d0aXLO UswdmqS92T6RNy9R5awfhmSB3Fx5t+o4lRrNqYTkp1oJxPX5M+32rmfH73qv5RbaLIQw bWETTDab7Z0QbwcVoXNhLCyQ/sZsGCE7IB85QxjGP5+LCZW38x05zxHVcz1zrjP5Vusc TEAv+nWXOiDzbyYV3d73JRcCHX24W3L51f9UHzpbTjyut0ZZ4J/9bHTlTf3HWz3AVrJC UPco6vLnbOICsj5r79bi5pbhk84SgRREWhjViRX0eojMPLUTphCxpmElelUJ4qaekfZG ZICQ== X-Gm-Message-State: AGi0PuYnfH+gwGTAKExLci6grpL3Xhf/qRYmt/325BpQexpfsJGJC00G vgv+ek88jE9ULeTM6AXR5X1R9/y+QRof X-Google-Smtp-Source: APiQypIhCYVKYMDKbZO4If3W8pkUvbQGyhxY2Ztvnnh0lFhQLXJUUg+ywqpMYQVJUmHsX0sbKWp4jxq3Bmbm X-Received: by 2002:a17:90a:e64e:: with SMTP id ep14mr6371239pjb.190.1587054062749; Thu, 16 Apr 2020 09:21:02 -0700 (PDT) Date: Thu, 16 Apr 2020 09:20:54 -0700 Message-Id: <20200416162058.201954-1-irogers@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.26.1.301.g55bc3eb7cb9-goog Subject: [PATCH v10 0/4] perf tools: add support for libpfm4 From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Yonghong Song , Andrii Nakryiko , Greg Kroah-Hartman , Thomas Gleixner , Igor Lubashev , Alexey Budankov , Florian Fainelli , Adrian Hunter , Andi Kleen , Jiwei Sun , yuzhoujian , Kan Liang , Jin Yao , Leo Yan , John Garry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org Cc: Stephane Eranian , Ian Rogers Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org This patch links perf with the libpfm4 library if it is available and NO_LIBPFM4 isn't passed to the build. The libpfm4 library contains hardware event tables for all processors supported by perf_events. It is a helper library that helps convert from a symbolic event name to the event encoding required by the underlying kernel interface. This library is open-source and available from: http://perfmon2.sf.net. With this patch, it is possible to specify full hardware events by name. Hardware filters are also supported. Events must be specified via the --pfm-events and not -e option. Both options are active at the same time and it is possible to mix and match: $ perf stat --pfm-events inst_retired:any_p:c=1:i -e cycles .... v10 addresses review comments from jolsa@redhat.com. v9 removes some unnecessary #ifs. v8 addresses review comments from jolsa@redhat.com. Breaks the patch into 4, adds a test and moves the libpfm code into its own file. perf list encoding tries to be closer to existing: ... skx pfm-events: UNHALTED_CORE_CYCLES [Count core clock cycles whenever the clock signal on the specific ... UNHALTED_REFERENCE_CYCLES [Unhalted reference cycles] INSTRUCTION_RETIRED [Number of instructions at retirement] INSTRUCTIONS_RETIRED [This is an alias for INSTRUCTION_RETIRED] BRANCH_INSTRUCTIONS_RETIRED [Count branch instructions at retirement. Specifically, this event ... MISPREDICTED_BRANCH_RETIRED [Count mispredicted branch instructions at retirement. ... BACLEARS [Branch re-steered] BACLEARS:ANY [Number of front-end re-steers due to BPU misprediction] BR_INST_RETIRED [Branch instructions retired (Precise Event)] BR_INST_RETIRED:CONDITIONAL [Counts all taken and not taken macro conditional branch ... ... and supports --long-desc/-v: ... BACLEARS [Branch re-steered] Code : 0xe6 BACLEARS:ANY [Number of front-end re-steers due to BPU misprediction] Umask : 0x01 : PMU: [default] Modif : PMU: [e] : edge level (may require counter-mask >= 1) ... Modif : PMU: [i] : invert (boolean) Modif : PMU: [c] : counter-mask in range [0-255] (integer) Modif : PMU: [t] : measure any thread (boolean) Modif : PMU: [intx] : monitor only inside transactional memory ... Modif : PMU: [intxcp] : do not count occurrences inside aborted ... Modif : perf_event: [u] : monitor at user level (boolean) Modif : perf_event: [k] : monitor at kernel level (boolean) Modif : perf_event: [period] : sampling period (integer) Modif : perf_event: [freq] : sampling frequency (Hz) (integer) Modif : perf_event: [excl] : exclusive access (boolean) Modif : perf_event: [mg] : monitor guest execution (boolean) Modif : perf_event: [mh] : monitor host execution (boolean) Modif : perf_event: [cpu] : CPU to program (integer) Modif : perf_event: [pinned] : pin event to counters (boolean) BR_INST_RETIRED [Branch instructions retired (Precise Event)] Code : 0xc4 BR_INST_RETIRED:CONDITIONAL [Counts all taken and not taken macro conditional branch ... Umask : 0x01 : PMU: [precise] v7 rebases and adds fallback code for libpfm4 events. The fallback code is to force user only priv level in case the perf_event_open() syscall failed for permissions reason. the fallback forces a user privilege level restriction on the event string, so depending on the syntax either u or :u is needed. But libpfm4 can use a : or . as the separator, so simply searching for ':' vs. '/' is not good enough to determine the syntax needed. Therefore, this patch introduces a new evsel boolean field to mark events coming from libpfm4. The field is then used to adjust the fallback string. v6 was a rebase. v5 was a rebase. v4 was a rebase on git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git branch perf/core and re-adds the tools/build/feature/test-libpfm4.c missed in v3. v3 is against acme/perf/core and removes a diagnostic warning. v2 of this patch makes the --pfm-events man page documentation conditional on libpfm4 behing configured. It tidies some of the documentation and adds the feature test missed in the v1 patch. Ian Rogers (1): perf doc: allow ASCIIDOC_EXTRA to be an argument Stephane Eranian (3): tools feature: add support for detecting libpfm4 perf pmu: add perf_pmu__find_by_type helper perf tools: add support for libpfm4 tools/build/Makefile.feature | 3 +- tools/build/feature/Makefile | 6 +- tools/build/feature/test-libpfm4.c | 9 + tools/perf/Documentation/Makefile | 4 +- tools/perf/Documentation/perf-record.txt | 11 + tools/perf/Documentation/perf-stat.txt | 10 + tools/perf/Documentation/perf-top.txt | 11 + tools/perf/Makefile.config | 13 ++ tools/perf/Makefile.perf | 6 +- tools/perf/builtin-list.c | 12 +- tools/perf/builtin-record.c | 8 + tools/perf/builtin-stat.c | 8 + tools/perf/builtin-top.c | 8 + tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c | 9 + tools/perf/tests/pfm.c | 207 +++++++++++++++++ tools/perf/tests/tests.h | 3 + tools/perf/util/Build | 2 + tools/perf/util/evsel.c | 2 +- tools/perf/util/evsel.h | 1 + tools/perf/util/parse-events.c | 30 ++- tools/perf/util/parse-events.h | 4 + tools/perf/util/pfm.c | 277 +++++++++++++++++++++++ tools/perf/util/pfm.h | 43 ++++ tools/perf/util/pmu.c | 11 + tools/perf/util/pmu.h | 1 + 26 files changed, 685 insertions(+), 15 deletions(-) create mode 100644 tools/build/feature/test-libpfm4.c create mode 100644 tools/perf/tests/pfm.c create mode 100644 tools/perf/util/pfm.c create mode 100644 tools/perf/util/pfm.h