From patchwork Wed Apr 1 11:03:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 1265145 Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=silabs.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=silabs.onmicrosoft.com header.i=@silabs.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-silabs-onmicrosoft-com header.b=lI2+gvsM; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 48sk1F5wC2z9sT9 for ; Wed, 1 Apr 2020 22:07:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732393AbgDALFG (ORCPT ); Wed, 1 Apr 2020 07:05:06 -0400 Received: from mail-bn7nam10on2089.outbound.protection.outlook.com ([40.107.92.89]:6053 "EHLO NAM10-BN7-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726445AbgDALE7 (ORCPT ); Wed, 1 Apr 2020 07:04:59 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PP0lYD0Fou87gbvQJvrwG0NJog3OEZVqxGpPFAH1Lw3kWKiGxDA4yZNgr6Gzjjdrzp9EkIU2An50WOiH76SMeXKV9MVsKh7S1ZADf2vIFZJff+lyAPM197w1TbnhhoEI99LQbln02//3DNaRHIhXbkDVvz9rOPcq6sLpHUCuJoVuhs+J58rId9fgIUIoRRGoSjWeSPK60AqEojEeTCsCUXxNzn/RRJmFE+ZYXbQ2ujHmvdewEJ9ZHivZkl0SHWgypQekG5Hfw6lSIszO9yU1ypRI42ip8PH4mgWs+eMURXtfLpvlnUUqgken77wqIfD3QZtaXDv/J9xzLecNwtmSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8hXEBmGdi+6ggl8GNIQen6Avc3J9TdGfh1DYAKqH4Y=; b=dXl3dagWDgX9HZXlGFAzxV0fHaqjkv+93u4RSnWVI4czxrbvtaGO0e4TAOroXs5ZWxvOObLGmeQxBOtM5IOAwMTjXRH/XAy6qFBBjndxe1JjUuT7HzdkdhE7fIry/oBwAWWw8gSsW51eGYuG9FoKJodkAppUzTahZ4MCQRROZ5iECmuQ2Th8u1VWOvbL0kkp1iR0vivU8Nxt2m83c/zL1kV9yuccM4EIov8HNWukJi2WK8hJ8R5A7YdxLV1ouZrri4mlUyz2Ec133p0SftbPqwJ69eVJdva9k7oxtresa86E4S1VcrE7oiDhxKVvCIKfYcTLXt8Mth1zUfba7xI6SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8hXEBmGdi+6ggl8GNIQen6Avc3J9TdGfh1DYAKqH4Y=; b=lI2+gvsMQPhKKxhTtwhwFdRwTUWL5caBvUnPhG7z14z1W6xwkHL7DD5qQArS9MBkIJRVDQs93oMrLRtr2jtRhduq69STVKKjOqmWQzgYxgFUXwR6eGmjQ85jVHHz3vbgr3YbTsNNJDQnp8uUxGLdebv0A0e/KiDephkqsKYX4F4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerome.Pouiller@silabs.com; Received: from MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) by MN2PR11MB4285.namprd11.prod.outlook.com (2603:10b6:208:191::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.20; Wed, 1 Apr 2020 11:04:20 +0000 Received: from MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3]) by MN2PR11MB4063.namprd11.prod.outlook.com ([fe80::ade4:5702:1c8b:a2b3%7]) with mapi id 15.20.2856.019; Wed, 1 Apr 2020 11:04:19 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 00/32] staging: wfx: rework the Tx queue Date: Wed, 1 Apr 2020 13:03:33 +0200 Message-Id: <20200401110405.80282-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SN4PR0501CA0156.namprd05.prod.outlook.com (2603:10b6:803:2c::34) To MN2PR11MB4063.namprd11.prod.outlook.com (2603:10b6:208:13f::22) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from pc-42.silabs.com (2a01:e35:2435:66a0:1265:30ff:fefd:6e7f) by SN4PR0501CA0156.namprd05.prod.outlook.com (2603:10b6:803:2c::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2878.9 via Frontend Transport; Wed, 1 Apr 2020 11:04:17 +0000 X-Mailer: git-send-email 2.25.1 X-Originating-IP: [2a01:e35:2435:66a0:1265:30ff:fefd:6e7f] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 49532a74-7511-4e73-c29d-08d7d62c6d1a X-MS-TrafficTypeDiagnostic: MN2PR11MB4285: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-Forefront-PRVS: 03607C04F0 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4063.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(136003)(366004)(346002)(376002)(39850400004)(396003)(7696005)(8676002)(1076003)(16526019)(186003)(6666004)(5660300002)(86362001)(4326008)(66574012)(52116002)(478600001)(66946007)(66476007)(54906003)(36756003)(8936002)(316002)(81156014)(6486002)(2906002)(66556008)(107886003)(81166006)(2616005); DIR:OUT; SFP:1101; Received-SPF: None (protection.outlook.com: silabs.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yyb6IcznTq1Dw7yq4jkQmWdTJr4qTPIR9O4wzwSBJxsnB4p7jNJtK3jtXsAyGz/MeML5rj+KVUI0WihDmJFA/+WTtsg0VCYNBFfjF4v+qgn+QXntuTJUXmX/NVTXpNvycI0VK91SEsLXMObtzbRM96wxgJ8PWsj0RLuoFWuBe6zorCRR3uRnvMYh7Na8vItPoerP43O1JmTVsnm6V6B/Wzd1TJeq5S0RSF9Jyr2BmXrWJTgZ5fyupfsch2UFyjz3Dfd3feAjRiUrrVh23ot4/AeIMMJylEn3WdrxOOs3tv+h4m0uF6pcAdLo0p8+ryMIOpPB17nJl+DDcfVoo1C5CvE4UkxEmhzs6dWHsCsF0ia8hEjgKBz7wvrVOkkujkgB16ScOPJtHY2UxTt3Ly3qH/k7a4IKVroaMdV4qltmpUqxMaft/Cv5kB7A+GZGldVx X-MS-Exchange-AntiSpam-MessageData: WP1QgPrkITihwFKirFcqftMNhSBRd8bdN6M5odKszTynqTVeUs9IbKYBxH+3266SzC1QonsvaCzOOLDHK9XkzNaaepDbqoquD39hb6k/vozBHxF0kUFeWgX88BmG1T3tUwTMZaPKim3QRAv5kiSqBZ1RZKcuvMriFVYZYCTDOKkQho9UhvarPUIX3KizJl4zAdXCMV3WRuoiLR+KEclkog== X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 49532a74-7511-4e73-c29d-08d7d62c6d1a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2020 11:04:19.7257 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /6YJcgb2tVL8pA7jZuBjrK0hrdnTC4HQKBw7tAPWR66sR1y+1lpK3dzRfs2Ys1CPzCjE8cB/si2TqVew6LbCVA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4285 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller This current implementation of the Tx queue is far more complex than necessary and its behavior is dubious on some corner cases. This series rework the Tx queue: - Simplify support for QoS (since device already do the job) - Simplify support for Power Saving stations (since mac80211 already do the job) - Improve support of Content After DTIM Beacon (CAB) when device is AP and some station use power save. - Improve robustness of flushing Jérôme Pouiller (32): staging: wfx: add sanity checks to hif_join() staging: wfx: do not stop mac80211 queueing during tx_policy upload staging: wfx: take advantage of ieee80211_{stop/start}_queues staging: wfx: remove "burst" mechanism staging: wfx: uniformize queue_id retrieval staging: wfx: drop useless queue_id field staging: wfx: avoid useless wake_up staging: wfx: simplify hif_handle_tx_data() staging: wfx: simplify wfx_tx_queues_empty() staging: wfx: drop unused argument in wfx_get_prio_queue() staging: wfx: simplify wfx_tx_queue_mask_get() staging: wfx: drop useless sta_asleep_mask staging: wfx: drop argument tx_allowed_mask since it is constant now staging: wfx: do not use link_map_cache to track CAB staging: wfx: drop useless link_map_cache staging: wfx: do not rely anymore on link_id to choose packet in queue staging: wfx: drop unused link_id field staging: wfx: drop unused raw_link_id field staging: wfx: rename wfx_tx_get_raw_link_id() staging: wfx: replace wfx_tx_queues_get_after_dtim() by wfx_tx_queues_has_cab() staging: wfx: introduce a counter of pending frames staging: wfx: change the way to choose frame to send staging: wfx: drop now useless field edca_params staging: wfx: drop struct wfx_queue_stats staging: wfx: simplify usage of wfx_tx_queues_put() staging: wfx: improve interface between data_tx.c and queue.c staging: wfx: relocate wfx_skb_dtor() prior its callers staging: wfx: repair wfx_flush() staging: wfx: wfx_flush() did not ensure that frames are processed staging: wfx: fix potential deadlock in wfx_tx_flush() staging: wfx: fix case where AP stop with CAB traffic pending staging: wfx: remove hack about tx_rate policies drivers/staging/wfx/bh.c | 4 +- drivers/staging/wfx/data_tx.c | 196 +++++-------- drivers/staging/wfx/data_tx.h | 5 +- drivers/staging/wfx/hif_tx.c | 2 + drivers/staging/wfx/main.c | 2 - drivers/staging/wfx/queue.c | 529 +++++++++++----------------------- drivers/staging/wfx/queue.h | 36 +-- drivers/staging/wfx/sta.c | 87 ++---- drivers/staging/wfx/sta.h | 2 - drivers/staging/wfx/wfx.h | 7 +- 10 files changed, 281 insertions(+), 589 deletions(-) Reviewed-by: Dan Carpenter