Message ID | 20200329225342.16317-1-joe@wand.net.nz |
---|---|
Headers | show |
Series | Add bpf_sk_assign eBPF helper | expand |
On Sun, Mar 29, 2020 at 3:53 PM Joe Stringer <joe@wand.net.nz> wrote: > > Introduce a new helper that allows assigning a previously-found socket > to the skb as the packet is received towards the stack, to cause the > stack to guide the packet towards that socket subject to local routing > configuration. The intention is to support TProxy use cases more > directly from eBPF programs attached at TC ingress, to simplify and > streamline Linux stack configuration in scale environments with Cilium. Applied. Patches 4 and 5 had warnings: progs/test_sk_assign.c:79:32: warning: ordered comparison between pointer and integer ('void *' and '__u32' (aka 'unsigned int')) if ((void *)tuple + tuple_len > skb->data_end) ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ I fixed them up.
On Mon, Mar 30, 2020 at 1:47 PM Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote: > > On Sun, Mar 29, 2020 at 3:53 PM Joe Stringer <joe@wand.net.nz> wrote: > > > > Introduce a new helper that allows assigning a previously-found socket > > to the skb as the packet is received towards the stack, to cause the > > stack to guide the packet towards that socket subject to local routing > > configuration. The intention is to support TProxy use cases more > > directly from eBPF programs attached at TC ingress, to simplify and > > streamline Linux stack configuration in scale environments with Cilium. > > Applied. > Patches 4 and 5 had warnings: > progs/test_sk_assign.c:79:32: warning: ordered comparison between > pointer and integer ('void *' and '__u32' (aka 'unsigned int')) > if ((void *)tuple + tuple_len > skb->data_end) > ~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~ > > I fixed them up. Thanks, I'll keep a closer eye on these in future.