Message ID | 20200225131938.120447-1-christian.brauner@ubuntu.com |
---|---|
Headers | show |
Series | net: fix sysfs permssions when device changes network | expand |
On Tue, Feb 25, 2020 at 02:19:29PM +0100, Christian Brauner wrote: > Hey everyone, > > /* v6 */ > This is v6 with two small fixups. I missed adapting the commit message > to reflect the renamed helper for changing the owner of sysfs files and > I also forgot to make the new dpm helper static inline. All of the sysfs and driver core bits look good to me now. Thanks for taking the time to update the documentation and other bits based on reviews. So now it's just up to the netdev developers to review the netdev parts :) The sysfs and driver core patches can all go through the netdev tree to make it easier for you. thanks, greg k-h
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Date: Wed, 26 Feb 2020 09:17:57 +0100 > On Tue, Feb 25, 2020 at 02:19:29PM +0100, Christian Brauner wrote: >> Hey everyone, >> >> /* v6 */ >> This is v6 with two small fixups. I missed adapting the commit message >> to reflect the renamed helper for changing the owner of sysfs files and >> I also forgot to make the new dpm helper static inline. > > All of the sysfs and driver core bits look good to me now. Thanks for > taking the time to update the documentation and other bits based on > reviews. > > So now it's just up to the netdev developers to review the netdev parts :) > > The sysfs and driver core patches can all go through the netdev tree to > make it easier for you. I'm fine with these changes, and will apply this series to net-next. Thanks everyone.
From: David Miller <davem@davemloft.net> Date: Wed, 26 Feb 2020 17:37:50 -0800 (PST) > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Date: Wed, 26 Feb 2020 09:17:57 +0100 > >> On Tue, Feb 25, 2020 at 02:19:29PM +0100, Christian Brauner wrote: >>> Hey everyone, >>> >>> /* v6 */ >>> This is v6 with two small fixups. I missed adapting the commit message >>> to reflect the renamed helper for changing the owner of sysfs files and >>> I also forgot to make the new dpm helper static inline. >> >> All of the sysfs and driver core bits look good to me now. Thanks for >> taking the time to update the documentation and other bits based on >> reviews. >> >> So now it's just up to the netdev developers to review the netdev parts :) >> >> The sysfs and driver core patches can all go through the netdev tree to >> make it easier for you. > > I'm fine with these changes, and will apply this series to net-next. Actually, you'll need to respin this with these warnings fixed, thanks: fs/sysfs/group.c: In function ‘sysfs_group_change_owner’: fs/sysfs/group.c:517:9: warning: unused variable ‘gid’ [-Wunused-variable] kgid_t gid; ^~~ fs/sysfs/group.c:516:9: warning: unused variable ‘uid’ [-Wunused-variable] kuid_t uid; ^~~
On Wed, Feb 26, 2020 at 07:06:44PM -0800, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Wed, 26 Feb 2020 17:37:50 -0800 (PST) > > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Date: Wed, 26 Feb 2020 09:17:57 +0100 > > > >> On Tue, Feb 25, 2020 at 02:19:29PM +0100, Christian Brauner wrote: > >>> Hey everyone, > >>> > >>> /* v6 */ > >>> This is v6 with two small fixups. I missed adapting the commit message > >>> to reflect the renamed helper for changing the owner of sysfs files and > >>> I also forgot to make the new dpm helper static inline. > >> > >> All of the sysfs and driver core bits look good to me now. Thanks for > >> taking the time to update the documentation and other bits based on > >> reviews. > >> > >> So now it's just up to the netdev developers to review the netdev parts :) > >> > >> The sysfs and driver core patches can all go through the netdev tree to > >> make it easier for you. > > > > I'm fine with these changes, and will apply this series to net-next. > > Actually, you'll need to respin this with these warnings fixed, thanks: Hm, I haven't caught those, sorry! Give me a few minutes to fix and do a test-compile and run. Christian